Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add originalPath to out.json #31

Open
daniellara opened this issue Jun 14, 2019 · 1 comment
Open

Add originalPath to out.json #31

daniellara opened this issue Jun 14, 2019 · 1 comment

Comments

@daniellara
Copy link

daniellara commented Jun 14, 2019

We have a project with many similar filenames (i.e. path_one/tag.js, path_two/tag.js, ... path_n/tag.js).

When passing puppeter-to-istanbul, these path and filenames are converted to tag.N.js for avoid conflicts at the time of writing these files in tmp folder, but if we pass the result to our reporter (similar to istanbul-reporter) we generate a lot of rows like tag.1.js, tag.2.js ... tag.N.js so it's complicated to follow the exact file that we want to look in the reporter. It is possible to include that "originalPath" in the out.json in order to use it in the reporter?

P.D. I have made some changes in puppeter-to-istanbul in my local to include the "originalPath" to the out.json generated, so if you want I can make a PR with these changes.

@bcoe
Copy link
Member

bcoe commented Jun 18, 2019

@daniellara I would be very open to PRs, I haven't been able to put much work against this repo (burried in other OSS work unfortunately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants