Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to change outputFile and filter coverage files #25

Closed
wants to merge 3 commits into from
Closed

Add options to change outputFile and filter coverage files #25

wants to merge 3 commits into from

Conversation

aadityataparia
Copy link

@aadityataparia aadityataparia commented Feb 4, 2019 •
edited
Loading

closes #15

Adds two options to PuppeteerToIstanbul.prototype.writeIstanbulFormat

Note: This doesn't change default behaviour

Usage

pti.write(coverage, options)

Options

option Description Default Value
outputFile Output coverage will be saved at this file path (can be relative to project root dir or an absolute path) ./.nyc_output/out.json
filter Function to filter coverage files. Coverage will only be saved if it returns true for given filePath (filePath) => true

Additional changes

Added tests for lib/puppeteer-to-istanbul.js with 100% coverage 🚀

@aadityataparia aadityataparia mentioned this pull request Feb 4, 2019
Open
@coveralls
Copy link

Pull Request Test Coverage Report for Build 106

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 104: 0.0%
Covered Lines: 72
Relevant Lines: 72
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 107

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 104: 0.0%
Covered Lines: 72
Relevant Lines: 72
💛 - Coveralls

@aadityataparia aadityataparia mentioned this pull request Feb 4, 2019
Closed
@aadityataparia aadityataparia changed the title Add options to change outputFIle and filter coverage files Add options to change outputFile and filter coverage files Feb 4, 2019
@ifiokjr
Copy link

ifiokjr commented Feb 22, 2019

Any updates on whether and when this might be merged?

@aadityataparia
Copy link
Author

Knock Knock! Someone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Save to specific folder, and only certain files to cover
3 participants
@aadityataparia @coveralls @ifiokjr