Mis-use of userindices

[dchansen]

The Siemens converter currently (ab)uses the user indices 5 and 6 for storing the kspace center line and partition number.

siemens_to_ismrmrd/main.cpp

Line 1164 in 2cb7998

ismrmrd_acq.idx().user[6] = scanhead.ushKSpaceCentrePartitionNo;

This causes issues with any code trying to group acquisitions together based on their idx, as neither of these parameters are indices.

Has the need for this been solved, so we could simply remove the lines?
Alternatively, if it is required for compatibility with legacy software, could we add a command line flag to disable this behavior?

[dchansen]

@xueh2 Do you know if this is fixed on your side?

[kspaceKelvin]

I think it makes sense to make this change in the long term. However, I think there is likely some user code that uses these fields and we should give ample warning about this change.

I propose that this functionality be controlled by a command line switch that is default to true, with a warning that the behaviour will change in a future version. Then we'll switch it to default false in 3 months with a version bump.

[fzimmermann89]

Is it still planned to eventually do the switch and deprecate the k-space center being stored in the user idx?