Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: dark mode #1702

Open
legallyfree opened this issue Dec 31, 2020 · 22 comments · Fixed by #2322
Open

Feature: dark mode #1702

legallyfree opened this issue Dec 31, 2020 · 22 comments · Fixed by #2322
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up released status/ready Ready to be worked

Comments

@legallyfree
Copy link

Is your feature request related to a problem? Please describe.
My eyes, I go blind at night when I see the screen, this window is very bright.

Describe the solution you'd like
They could place a selection of themes to change the colors to suit one.

Describe alternatives you've considered
use the colors used by gtk / kde apps and use those colors / themes

Additional context
try to change the dependency of the use of npm for yarn, I use yarn instead of npm but well it is not so important but I must mention it since npm is not the only one.

@jessicaschilling
Copy link
Contributor

Thanks @legallyfree - it's on our radar for future releases, so thanks for the additional vote.

@jessicaschilling jessicaschilling transferred this issue from ipfs/ipfs-desktop Jan 4, 2021
@jessicaschilling
Copy link
Contributor

jessicaschilling commented Jan 4, 2021

Additional context for anyone who comes across this issue:

  • We'd very much like to include a dark-mode option in Web UI (and, by extension, Desktop)
  • Current timeline would involve including this work in a larger-scale revisiting of Web UI/Desktop, likely in Q2/3 2021
  • If anyone is interested in PRing something earlier, contributions are most welcome!

@lidel
Copy link
Member

lidel commented Oct 16, 2021

If someone wants to work on this:

@ipfs ipfs deleted a comment from welcome bot Oct 16, 2021
@ipfs ipfs deleted a comment from welcome bot Oct 16, 2021
@lidel lidel added exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up labels Oct 16, 2021
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Jul 19, 2022
@SgtPooki SgtPooki added the status/ready Ready to be worked label Dec 2, 2022
@SgtPooki SgtPooki moved this from Needs Grooming to Planned / Backlog in IPFS-GUI (PL EngRes) Dec 2, 2022
@KaKi87
Copy link

KaKi87 commented Feb 29, 2024

Hello,
Any news on this ?
Thanks

@voidvoxel
Copy link

Photosensitive user here; I sadly just had to uninstall the desktop app due to the blindingly-bright screen with no dark mode option. Support for dark mode would be greatly appreciated! I'll be sticking to the CLI for now 😊

@Artoria2e5
Copy link

Artoria2e5 commented Jun 20, 2024

The colors are pretty spread out in the js files. Guess a theme-switch button will really be needed -- no easy path with only changing a CSS file with @media (prefers-color-scheme). Well, I mean, you can do the same query with JS, but if you're changing the JS you might as well add a button.

But then there are CSS files. Maybe it's easier to not add a button after all, or otherwise we'd have to move them to JS to make them conditional on manual dark/light selection -- because Firefox doesn't do @container with custom properties yet.

@kaf-lamed-beyt
Copy link
Contributor

If someone wants to work on this:

hi @lidel, can you assign this to me so I can attempt it

@lidel
Copy link
Member

lidel commented Jan 28, 2025

Sure, feel free to work on this and ping when PR is ready for review.

@lidel
Copy link
Member

lidel commented Jan 28, 2025

In case its useful for testing, you can force brave and google chrome to run in dark mode via --force-dark-mode i think

@kaf-lamed-beyt
Copy link
Contributor

Alright, I'll do this too

@lidel
Copy link
Member

lidel commented Feb 26, 2025

#2322 is a good start but missed some key parts of UI that makes it unusable on systems with Dark Mode preference. Below feedback based on bafybeichbsr7jzwnqnlyb3tqjk6unhrwzwe74rnsnhi6hn3ovtr3tx6yk4 (latest master branch, https://github.com/ipfs/ipfs-webui/actions/runs/13554420729/job/37885554927#step:11:7).

@SgtPooki @kaf-lamed-beyt mind reverting until below are addressed? or is the plan to address below before next release?

  1. status page → graph contrast is too high

    Image

  2. status page → Tutorial:

    Image

  3. Status page → Addresses

    Image

  4. Context menus and all modals on Files screen:

    Image
    Image
    Image
    etc.

  5. Explore landing screen has white box:

    Image

  6. Exploring DAG is unreadable:

    Image

  7. Peers screen → Add connection modal is unreadable

    Image

  8. Settings screen → Add pinning service and IPNS modals are unreadable:

    Image
    Image

@lidel lidel reopened this Feb 26, 2025
@kaf-lamed-beyt
Copy link
Contributor

kaf-lamed-beyt commented Feb 26, 2025

Ah! Crap! I missed all those modals and context menus.

I'll try opening a new PR for these, @lidel, if that's okay. It is mostly just updates to the respective styles if I'm not mistaken.

For the addresses UI, I couldn't reproduce that. Is there a way you got the addresses to show? Do I have to include some type of input or somn'?

Kindly walk me through, thanks.

@SgtPooki
Copy link
Member

FYI I reverted the dark mode changes so if you could throw that back together with the additional fixes that would be great.

For the addresses UI, I couldn't reproduce that. Is there a way you got the addresses to show? Do I have to include some type of input or somn'?

The addresses should show after your node has been running for a little bit and then you just click the little ^ Advanced toggle to show the other windows

@kaf-lamed-beyt
Copy link
Contributor

Definitely. I'll get to it, @SgtPooki

@kaf-lamed-beyt
Copy link
Contributor

@SgtPooki, I'm done with the updates... I'm guessing I'd need to create a new PR, yeah?

@lidel, looking at the explore page... I think it depends on this package ipld-explorer-components/pages. I couldn't find the exact components rendering the UI on that route and on /explore/[cid]

@lidel
Copy link
Member

lidel commented Feb 27, 2025

@kaf-lamed-beyt ipld-explorer-components live in https://github.com/ipfs/ipld-explorer-components/ – open a companion PR in that repo.

@kaf-lamed-beyt
Copy link
Contributor

alright, thanks! I'll set that up.

@kaf-lamed-beyt
Copy link
Contributor

but, wait... @lidel, how would you suggest I go about this? Will I include the theme context I already have here in that repo? how does it work? can you walk me through?

@SgtPooki
Copy link
Member

SgtPooki commented Feb 28, 2025

but, wait... @lidel, how would you suggest I go about this? Will I include the theme context I already have here in that repo? how does it work? can you walk me through?

@kaf-lamed-beyt I think what we would need to do is add some CSS to ipld-explorer-components with a parent selector of [data-theme='dark'] to handle the display.. and we can leave it at that. It should then get the config from ipfs-webui and display things with the appropriate theme

@kaf-lamed-beyt
Copy link
Contributor

alright, that sounds good @SgtPooki. I'll get to it and let you know if I run into any blocker(s).

@kaf-lamed-beyt
Copy link
Contributor

@SgtPooki, I've opened a PR in the explorer-components repo.

@ipfs-gui-bot

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/beginner Can be confidently tackled by newcomers good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up released status/ready Ready to be worked
Projects
No open projects
Status: Planned / Backlog
Development

Successfully merging a pull request may close this issue.

9 participants