-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: dark mode #1702
Comments
Thanks @legallyfree - it's on our radar for future releases, so thanks for the additional vote. |
Additional context for anyone who comes across this issue:
|
If someone wants to work on this:
|
Hello, |
Photosensitive user here; I sadly just had to uninstall the desktop app due to the blindingly-bright screen with no dark mode option. Support for dark mode would be greatly appreciated! I'll be sticking to the CLI for now 😊 |
The colors are pretty spread out in the js files. Guess a theme-switch button will really be needed -- no easy path with only changing a CSS file with But then there are CSS files. Maybe it's easier to not add a button after all, or otherwise we'd have to move them to JS to make them conditional on manual dark/light selection -- because Firefox doesn't do |
hi @lidel, can you assign this to me so I can attempt it |
Sure, feel free to work on this and ping when PR is ready for review. |
In case its useful for testing, you can force brave and google chrome to run in dark mode via |
Alright, I'll do this too |
#2322 is a good start but missed some key parts of UI that makes it unusable on systems with Dark Mode preference. Below feedback based on @SgtPooki @kaf-lamed-beyt mind reverting until below are addressed? or is the plan to address below before next release?
|
Ah! Crap! I missed all those modals and context menus. I'll try opening a new PR for these, @lidel, if that's okay. It is mostly just updates to the respective styles if I'm not mistaken. For the addresses UI, I couldn't reproduce that. Is there a way you got the addresses to show? Do I have to include some type of input or somn'? Kindly walk me through, thanks. |
FYI I reverted the dark mode changes so if you could throw that back together with the additional fixes that would be great.
The addresses should show after your node has been running for a little bit and then you just click the little |
Definitely. I'll get to it, @SgtPooki |
@kaf-lamed-beyt ipld-explorer-components live in https://github.com/ipfs/ipld-explorer-components/ – open a companion PR in that repo. |
alright, thanks! I'll set that up. |
but, wait... @lidel, how would you suggest I go about this? Will I include the theme context I already have here in that repo? how does it work? can you walk me through? |
@kaf-lamed-beyt I think what we would need to do is add some CSS to ipld-explorer-components with a parent selector of |
alright, that sounds good @SgtPooki. I'll get to it and let you know if I run into any blocker(s). |
Is your feature request related to a problem? Please describe.
My eyes, I go blind at night when I see the screen, this window is very bright.
Describe the solution you'd like
They could place a selection of themes to change the colors to suit one.
Describe alternatives you've considered
use the colors used by gtk / kde apps and use those colors / themes
Additional context
try to change the dependency of the use of npm for yarn, I use yarn instead of npm but well it is not so important but I must mention it since npm is not the only one.
The text was updated successfully, but these errors were encountered: