bug: Focus state at ion-select with interface of action-sheet using TalkBack #29857
Closed
3 tasks done
Labels
Comments
|
Thank you for submitting the issue! I was as able to replicate this. A solution should be implemented soon! |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 24, 2024
Issue number: resolves #29857 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Screen readers like Android Talkback would not have the focus ring on the correct element. For example, Talkback would announce the buttons correctly within action sheet but the focus ring was no where to be seen. After digging around, the focus rings are located out of screen because the action sheet is mounted to the DOM out of the screen first then transitions into the screen. There are some screen readers that do not behave as expected when an element uses `transform` styles like action sheet. https://github.com/user-attachments/assets/5a700bcc-3149-47a9-96ff-0aef99dd2bb3 ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - When an overlay is being animated (presenting or dismissing), the overlay will hide from screen readers. This allows the element to navigate to its correct destination for screen readers to interact with. Plus, we shouldn't allow screen readers to interact with content in the middle of an animation. It could lead to some confusion. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: 8.3.3-dev.11729276019.194c165c **A physical Android device will be needed, the issue does not appear in simulators** Components that need to be tested because they use overlays: - Action sheet - Alert - Loading - Modal - Popover - Select w/ action sheet interface - Select w/ alert interface - Select w/ popover interface - Toast How to test: 1. Create a starter app (any framework will do) 2. Add an action sheet 3. Build app for mobile devices ``` ionic build ionic cap add ios ionic cap add android ionic cap copy && ionic cap sync ``` 4. Open the app in Android Studio: `ionic cap open android` 5. Connect the Android device to Android Studio 6. Open app in Android device 7. Launch Talkback 8. Navigate back to the app 9. Open action sheet 10. Swipe over to the action sheet's buttons 11. Notice that the buttons don't have a focus ring 12. Go back to the starter 4. Install the dev build 5. Add the components to the app 6. Sync app: `ionic cap copy && ionic cap sync` 13. Relaunch the app on the Android device 14. Verify that the focus ring appears on the action sheet's buttons 15. Verify that the other overlays are working as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Ionic Framework Version
v7.x
Current Behavior
We can clearly see that when TalkBack is turned on and start to read options in ion-select, focus state of HTML element is out of bounds.
Important to note
This is not happening always, the best (to reproduce this) will be to test it when you scroll page a bit, and then open a ion-select
Screen_Recording_20240911_125502_Chrome.1.mp4
Expected Behavior
focus of HTML element to be around correctly focused option
Steps to Reproduce
Code Reproduction URL
https://angular-kzrikb.stackblitz.io/
Ionic Info
Ionic:
Ionic CLI : 7.0.1
Ionic Framework : @ionic/angular 7.6.2
@angular-devkit/build-angular : 17.0.8
@angular-devkit/schematics : 17.0.8
@angular/cli : 17.0.8
@ionic/angular-toolkit : 10.0.0
Capacitor:
Capacitor CLI : 5.6.0
@capacitor/android : 5.6.0
@capacitor/core : 5.6.0
@capacitor/ios : 5.6.0
Cordova:
Cordova CLI : not installed
Cordova Platforms : not available
Cordova Plugins : not available
Utility:
cordova-res : not installed globally
native-run : 2.0.0
System:
NodeJS : v18.20.0
npm : 10.5.0
OS : Windows 10
Additional Information
No response
The text was updated successfully, but these errors were encountered: