Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CRAM files #93

Open
AlistairNWard opened this issue Jul 31, 2018 · 4 comments
Open

Handle CRAM files #93

AlistairNWard opened this issue Jul 31, 2018 · 4 comments

Comments

@AlistairNWard
Copy link
Member

No description provided.

@anderspitman
Copy link
Member

@AlistairNWard do you have a good CRAM dataset I can use to start playing with this?

@AlistairNWard
Copy link
Member Author

We should probably update the text prompts when this is working. E.g. on the landing page, the button text is "choose bam url", and this should probably become "choose bam/cram url". Similarly, when you click on that button, the text box that appears should be updated to BAM/CRAM URL etc.

@anderspitman
Copy link
Member

I agree. I've actually been thinking a bit about how we want the UX to work here. Is it reasonable to force the user to use .bam and .cram extensions on their files? If we enforce that, it makes a lot of things simpler. Otherwise we'll need to implement a bunch of logic deeper down to verify file types and whatnot. But I'm assuming people are going to want to use public datasets a lot and I'm not sure if URLs ever end in something other than the correct extension.

@AlistairNWard
Copy link
Member Author

Yes, it's reasonable to enforce files to have those extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants