-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Functions crash in IOS Release Mode only #8369
Comments
Hey 👋 ! I've got good news and bad news - good news first. Lucky winner, this crash doesn't have a lot of information but I reproduce it immediately in our test harness! (this is a rare thing, and usually the hardest part of the triage effort)
bad news is, yes, there is some sort of unexpected crash in iOS release mode - obviously we test debug mode in our day to day so we never saw this. I'm going to open a PR tagged to close this bug but please understand all it is doing is setting up our e2e test harness to allow for release builds + runs, it did not before. No fix yet unfortunately |
Thanks for the good news lol! |
Is there any news here? Unfortunately this problem is blocking us |
Any news? Encountering the same issue here. |
Not even downgrading fixed it for me. What a strange ride. As a workaround, cook your own callable method. |
No progress yet - sorry - we do reproduce it and I have a branch with the reproduction, as mentioned, but haven't had a chance to dig in yet. Likely won't for a day or two - anyone else is welcome to investigate of course |
It is possible to use fetch directly as @JFGHT mentions, and I've done that myself for other reasons in other spots - so that is a possible workaround if you're really blocked. But of course the APIs supported by firebase-js-sdk should be supported here and also of course they shouldn't crash - not trying to say otherwise |
After hours of debugging I finally realized it was with firebase functions. Just commenting here so Im notified when fixed. |
Truly sorry for the lost time there @Egehanozsoy - most unfortunate. Mostly commenting for you or for any future folks - you can just hit the "subscribe" button on the right side of the github web UI to get notifications, commenting subscribes as a side effect but there's no need to comment to subscribe, you can just hit that button on any PR or issue. This has a nifty opposite feature as well - if you're on one of those issues that generates a ridiculous pile of notifications you can comment as needed but also use the button to unsubscribe for blessed peace :-) |
Will this be fixed soon? Urgent need to deploy to testflight |
Issue
Describe your issue here
In my IOS project, when making a call to firebase functions in Release mode, I am encountering -[NSNull length]: unrecognized selector error.
Interestingly, the call works fine when running in Debug mode on IOS. On Android, everything works correctly in both Debug and Release modes. I'll also note that authorization calls and calls to firestore work fine in both release and debug mode for both platforms.
In the "JavaScript" section of the provided bug reporting template, I included the simple function call that is triggering the error.
The crash logs do not provide a lot of detail and I have spent numerous hours trying to figure out what is happening, with no luck.
The only error I receive:
"libc++abi: terminating due to uncaught exception of type facebook::jsi::JSError: Exception in HostFunction: -[NSNull length]: unrecognized selector sent to instance 0x1e4877140
Error: Exception in HostFunction: -[NSNull length]: unrecognized selector sent to instance 0x1e4877140"
Additionally, Xcode indicates the (red) X next to Thread 2 Queue : com.meta.react.turbomodulemanager.queue (serial)
The crash logs do not point to any particular line, but I did see that within the functions library/pod, the Functions file on line 486 the does point to an NSNull() variable:
let data = data ?? NSNull()
Just a wild guess at this point, no idea. Please advise, thanks.
Project Files
Javascript
export async function getFastFinAccountsHelper(id){ try{
}
package.json
:# N/A
firebase.json
for react-native-firebase v6:# N/A
iOS
Click To Expand
ios/Podfile
:AppDelegate.m
:Android
Click To Expand
Have you converted to AndroidX?
android/gradle.settings
jetifier=true
for Android compatibility?jetifier
for react-native compatibility?android/build.gradle
:// N/A
android/app/build.gradle
:// N/A
android/settings.gradle
:// N/A
MainApplication.java
:// N/A
AndroidManifest.xml
:<!-- N/A -->
Environment
Click To Expand
react-native info
output:react-native-firebase
version you're using that has this issue:e.g. 21.11.0
Firebase
module(s) you're using that has the issue:@react-native-firebase/functions
TypeScript
?N
React Native Firebase
andInvertase
on Twitter for updates on the library.The text was updated successfully, but these errors were encountered: