Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code block contrast is too high #273

Open
jenshor opened this issue Feb 20, 2023 · 1 comment
Open

fix: code block contrast is too high #273

jenshor opened this issue Feb 20, 2023 · 1 comment
Assignees

Comments

@jenshor
Copy link
Contributor

jenshor commented Feb 20, 2023

First of all, thanks for the great tool and I really like the redesign of docs.page.

Description

I noticed that the contrast of the code block is quite high for the light theme as the code block seems to be quite black-ish in contrast to the white-ish background.

image

When compared to the dark theme, the code block integrates better with the background as the background is black-ish and the code block is gray-ish.

image

Suggestion
Lightening the code block background for the light theme might make the docs more pleasing to the eye and easier to read.

Additional notes
As this issue is quite opinionated feel free to let me know what you think 😀

@Ehesp
Copy link
Member

Ehesp commented Feb 20, 2023

Ah interesting... I did actually do this on purpose, as a fairly well known company also has this type of contrast in their docs too for code blocks. I'll have to change the tokenization colours too if we go ahead here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants