-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon is not working in our repository #241
Comments
Huh, social preview is not working as well :( |
Hey, thanks for raising this! I took a look at your config file, and https://github.com/leancodepl/patrol/blob/master/docs/assets/preview.jpg?raw=true As a workaround until a fix comes in, changing I'll look into this ASAP though |
Also note that twitter and other sites will cache social previews, so any changes may take a while to appear. |
Thanks a lot for your help, will try out the workarounds tomorrow. |
using tips from invertase/docs.page#241 (comment)
@bartekpacia Might need to re-added, but |
Yeah, it works. Done in leancodepl/patrol#744. It'd be also great if we were able to specify |
Ah that needs JavaScript to do that from what I remember - I'll take a look. |
Oh, or something like <link rel="icon" href="/favicon.ico?dark" media="(prefers-color-scheme:dark)">
<link rel="icon" href="/favicon.ico?light" media="(prefers-color-scheme:light)"> |
Repository concerned: https://github.com/leancodepl/patrol
I think I have set the correct
favicon
in our docs.json and reference the correct asset, but the favicon is still the default one. I'd be very grateful if somebody of you, dear creators, took a look at our repository and told me what I'm doing wrong 😅The text was updated successfully, but these errors were encountered: