Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerbank collector is always set to "COLLECTOR_CLUSTERED" => "true", leads to warning level log noise if not in a cluster #8250

Open
heapdavid opened this issue Aug 13, 2024 · 0 comments

Comments

@heapdavid
Copy link

It's not possible to disable fingerbank collector clustering in conf/fingerbank.conf, as clustering is enabled and hard-coded in /usr/local/fingerbank/collector/set-env-fingerbank-conf.pl

...
my %TO_SET = (
    "FINGERBANK_API_KEY" => $Config{upstream}->{api_key},,
    "COLLECTOR_DELETE_INACTIVE_ENDPOINTS" => $Config{collector}->{inactive_endpoints_expiration} . "h",
    "COLLECTOR_ARP_LOOKUP" => is_enabled($Config{collector}->{arp_lookup}) ? "true" : "false",
    "COLLECTOR_QUERY_CACHE_TIME" => $Config{collector}->{query_cache_time} . "m",
    "PORT" => $Config{collector}->{port},
    "COLLECTOR_ENDPOINTS_DB_PATH" => $COLLECTOR_ENDPOINTS_DATA_FILE,
    "COLLECTOR_ENDPOINTS_CACHE_PATH" => $COLLECTOR_ENDPOINTS_CACHE_FILE,
    "COLLECTOR_IP_MAPS_DB_PATH" => $COLLECTOR_IP_MAPS_FILE,
    "COLLECTOR_DB_PERSISTENCE_INTERVAL" => $Config{collector}->{db_persistence_interval} . "s",
    "COLLECTOR_CLUSTER_RESYNC_INTERVAL" => $Config{collector}->{cluster_resync_interval} . "s",
    "COLLECTOR_CLUSTERED" => "true",
    "GOGC" => "100",
    "GODEBUG" => "gctrace=0",
    "HTTP_PROXY" => fingerbank::Util::get_proxy_url("http"),
    "HTTPS_PROXY" => fingerbank::Util::get_proxy_url("http"),
    "COLLECTOR_CONTACT_PEERS" => (join ",", map{ $_->{management_ip} } @{get_servers()}),
    "COLLECTOR_ODA_PEERS_DISCOVERY_URL" => "http://localhost:22226/api/v1/pfconnector/all-fingerbank-collector-endpoints",
);
...

leading to warning log lines:

Aug 13 00:01:27 [REDACTED] /usr/local/fingerbank/collector/fingerbank-collector[280511]: t=2024-08-13T00:01:27+0100 lvl=warn msg="Couldn't find a peer that has more uptime than this collector. Will not sync from anybody." pid=280511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant