Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent return key behaviour when editing #10401

Open
zorae opened this issue Jan 29, 2025 · 1 comment
Open

Inconsistent return key behaviour when editing #10401

zorae opened this issue Jan 29, 2025 · 1 comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Response Issues which require feedback from lead Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Bug Something isn't working. [managed]

Comments

@zorae
Copy link

zorae commented Jan 29, 2025

Problem

When editing an edition, writing something in the ID Numbers field and pressing the return key causes the ID to be added. But when trying to do the same with the Contributors or Classifications field, pressing return causes all changes to be saved and discards whatever you wrote in the field.

Reproducing the bug

  1. Go to any edition’s edit page
  2. Focus the Contributors or Classifications text input field
  3. Type any valid text
  4. With the text field still focused, press the return key on your keyboard
  • Expected behavior: The text you just wrote gets added as a contributor/classification
  • Actual behavior: The text gets discarded, but any other changes you made get saved to the edition. The return key behaves like the Save button at the bottom of the page.

Context

  • Browser (Chrome, Safari, Firefox, etc): Safari
  • OS (Windows, Mac, etc): iPadOS 18.3
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod
    Note: My keyboard doesn’t have a dedicated enter key, so I’m not sure if the problem occurs both with return and enter keypresses.

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@zorae zorae added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jan 29, 2025
@cdrini cdrini added Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Feb 3, 2025
@techy4shri
Copy link
Contributor

I would like to work on this issue please.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Response Issues which require feedback from lead Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

3 participants