Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show IA identifiers when item is borrowable or open #10391

Open
mekarpeles opened this issue Jan 28, 2025 · 1 comment
Open

Only show IA identifiers when item is borrowable or open #10391

mekarpeles opened this issue Jan 28, 2025 · 1 comment
Assignees
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 2 Important, as time permits. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed]

Comments

@mekarpeles
Copy link
Member

Problem

The following block of code should only get shown if the edition is borrowable or open
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/type/edition/view.html#L447-L449

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@mekarpeles mekarpeles added Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 2 Important, as time permits. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed] labels Jan 28, 2025
@mekarpeles mekarpeles added this to the Sprint 2025-02 milestone Jan 28, 2025
@hornc
Copy link
Collaborator

hornc commented Jan 28, 2025

Is that really true @mekarpeles ? archive.org can be used as a source of metadata verification, and sighting the title page or cover can be helpful, even if the full contents are not accessible. We also have previewable books which can be linked from Wikipedia and other sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 2 Important, as time permits. [managed] Theme: Identifiers Issues related to ISBN's or other identifiers in metadata. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

3 participants