Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IdentifiersInput Vue component to not need isEdition checks #10301

Closed
cdrini opened this issue Jan 9, 2025 · 7 comments · Fixed by #10307
Closed

Refactor IdentifiersInput Vue component to not need isEdition checks #10301

cdrini opened this issue Jan 9, 2025 · 7 comments · Fixed by #10307
Assignees
@schu96
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Jan 9, 2025 •
edited
Loading

I think we can remove all the references to isEdition (or similar) from this code. Most of the logic was just checking for saveIdentifiersAsList , and now that that abstraction has come out, I think these can be cleared up as well! Instead of edition_popular, we can just have a popular_ids="['project_gutenberg', 'isbn']" and so on. This doesn't have to be edition-specific, and can just be a list of identifiers to be extracted from the pool of identifiers to be listed at the top. And then you can just check if there are any popular identifiers.

(Addendum of #10032)

Relevant Files

https://github.com/internetarchive/openlibrary/blob/master/openlibrary/components/IdentifiersInput.vue

Stakeholders

@schu96
@cdrini cdrini added Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Jan 9, 2025
@cdrini cdrini mentioned this issue Jan 9, 2025
Merged
@schu96
Copy link
Contributor

schu96 commented Jan 9, 2025

@cdrini I'd like to be assigned to this issue

@cdrini
Copy link
Collaborator Author

cdrini commented Jan 9, 2025

Awesome, thank you @schu96 !

@schu96 schu96 mentioned this issue Jan 9, 2025
Merged
@github-actions GitHub Actions
Copy link

This issue has been marked "Needs: Review Assignee" since there have been no updates within the past two weeks

@github-actions github-actions bot added the Needs: Review Assignee Issues that may have been abandoned by assignees label Jan 24, 2025
@schu96
Copy link
Contributor

schu96 commented Jan 24, 2025

Bump, awaiting review

@github-actions github-actions bot added Needs: Response Issues which require feedback from lead and removed Needs: Review Assignee Issues that may have been abandoned by assignees labels Jan 24, 2025
@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Jan 27, 2025
@github-actions GitHub Actions
Copy link

This issue has been marked "Needs: Review Assignee" since there have been no updates within the past two weeks

@github-actions github-actions bot added Needs: Review Assignee Issues that may have been abandoned by assignees Needs: Response Issues which require feedback from lead labels Feb 11, 2025
@schu96
Copy link
Contributor

schu96 commented Feb 11, 2025

Bump

@github-actions github-actions bot removed the Needs: Review Assignee Issues that may have been abandoned by assignees label Feb 12, 2025
@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Feb 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

This issue has been marked "Needs: Review Assignee" since there have been no updates within the past two weeks

@github-actions github-actions bot added Needs: Review Assignee Issues that may have been abandoned by assignees Needs: Response Issues which require feedback from lead and removed Needs: Review Assignee Issues that may have been abandoned by assignees labels Mar 5, 2025
@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schu96 schu96

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Refactor/Clean-up Issues related to reorganization/clean-up of data or code (e.g. for maintainability). [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up and rename computed variables schu96/openlibrary
2 participants
@cdrini @schu96