Clean up and rename computed variables #10307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10307 +/- ##
==========================================
- Coverage 17.31% 17.27% -0.04%
==========================================
Files 87 87
Lines 4835 4845 +10
Branches 856 860 +4
==========================================
Hits 837 837
- Misses 3471 3477 +6
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdrini
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Awesome, thanks for tackling @schu96 !! I think we can do a bit more to making this component less aware of the isEdition logic; by making it less tightly coupled to this notion, we should be able to DRY up a few of these methods, since there are a number of shared patterns. A few spots of feedback for you! Let me know if you have any questions 😊
cdrini
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
schu96
changed the title
cdrini
requested changes
Feb 18, 2025
cdrini
added
the
Needs: Submitter Input
cdrini
reviewed
Feb 18, 2025
schu96
force-pushed
the
10301/refactor/remove-isEdition-references
branch
from
38de33a to
f11f351
Compare
github-actions
bot
removed
the
Needs: Submitter Input
cdrini
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10301
Refactor
Technical
Remove computed
isEditionvariable and usesaveIdentifiersAsListto ensure component still functions properly when saving Author identifiers vs Edition/Work identifiers.Removes props initially used to create an ordered dropdown list for identifiers, add a popular identifier list within the IdentifiersInput.vue for easier future maintenance.
Testing
Run
docker compose up -dand thendocker-compose run --rm home npx vue-cli-service build --watch --no-clean --mode production --dest static/build/components/production --target wc --name ol-IdentifiersInput openlibrary/components/IdentifiersInput.vueSign in using the OpenLibrary dev account or as a patron
Navigate to an edition and click on the edit button. Click on the identifiers component and check that the identifiers dropdown list contains two sets of identifiers separated by a non-selectable option with three dashes.
Within the same edit page, select the Work Details tab. Click on the identifiers component and verify that the work identifiers dropdown list contains only one set of identifiers without the three dashes option.
Navigate to an author page and click on the edit button. The dropdown list should also have one set of identifiers without the three dashes option.
Screenshot
Editions dropdown
Work dropdown
Author dropdown
Stakeholders
@cdrini