Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/data_store.rb: resolve rubocop Naming/AccessorMethodName issue #403

Closed
rli9 opened this issue Feb 5, 2025 · 1 comment
Closed

lib/data_store.rb: resolve rubocop Naming/AccessorMethodName issue #403

rli9 opened this issue Feb 5, 2025 · 1 comment
Assignees
@j-chiam
Labels
bug hackathon

Comments

@rli9
Copy link

rli9 commented Feb 5, 2025

Reproduce

lkp-tests$ rubocop lib/data_store.rb

lib/data_store.rb:738:9: C: Naming/AccessorMethodName: Do not prefix writer method names with set_.
    def set_date(date)
        ^^^^^^^^

1 file inspected, 1 offense detected

Reference
https://github.com/intel/lkp-tests/wiki/Coding-Standard#rubocop

Note
Besides the fix of rubocop issue, it is required to update the caller side to use new API
yenyeeong added a commit to j-chiam/lkp-tests that referenced this issue Mar 3, 2025
@yenyeeong
Fixed Issue 403
bc69e1c 
Fixed issue intel#403

Signed-off-by: Ong Yen Yee <[email protected]>
Signed-off-by: Ang Yee Teng <[email protected]>
@j-chiam
Copy link

j-chiam commented Mar 3, 2025

LKP_Team1 is working on this issue

yenyeeong added a commit to j-chiam/lkp-tests that referenced this issue Mar 3, 2025
@yenyeeong
Fixed issue 403
13f58de 
Fixed Issue intel#403
Signed-off-by: Ong Yen Yee <[email protected]>
Signed-off-by: Ang Yee Teng <[email protected]>
yenyeeong added a commit to j-chiam/lkp-tests that referenced this issue Mar 3, 2025
@yenyeeong
Resolved rubocop Naming/AccessorMethodName issue 403
70397d3 
Fixed Issue intel#403

Signed-off-by: Ong Yen Yee <[email protected]>
Signed-off-by: Ang Yee Teng <[email protected]>
yenyeeong added a commit to j-chiam/lkp-tests that referenced this issue Mar 3, 2025
@yenyeeong
Resolve rubocop Naming/AccessorMethodName issue 403
085bbf8 
Fixed issue intel#403

Signed-off-by: Ong Yen Yee <[email protected]>
Signed-off-by: Ang Yee Teng <[email protected]>
@j-chiam j-chiam mentioned this issue Mar 3, 2025
Merged
yenyeeong added a commit to j-chiam/lkp-tests that referenced this issue Mar 3, 2025
@yenyeeong
Resolve rubocop Naming/AccessorMethodName issue 403
277b030 
Fixed issue intel#403

Signed-off-by: Ong Yen Yee <[email protected]>
Signed-off-by: Ang Yee Teng <[email protected]>
rli9 pushed a commit that referenced this issue Mar 3, 2025
@j-chiam @yenyeeong
lib/data_store.rb: resolve rubocop Naming/AccessorMethodName issue
5b8282c 
Fixed issue #403

Signed-off-by: Ong Yen Yee <[email protected]>
Signed-off-by: Ang Yee Teng <[email protected]>
Co-authored-by: Ong, Yen Yee <[email protected]>
@rli9 rli9 closed this as completed Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-chiam j-chiam

Labels
bug hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rli9 @j-chiam