Check unused variables in tests (pytorch#127498)

Enables unused variable checks in CMake.

Pull Request resolved: pytorch#127498
Approved by: https://github.com/ezyang

Author: cyyever

caffe2/CMakeLists.txt

@@ -1810,9 +1810,6 @@ if(BUILD_TEST)
     target_include_directories(${test_name} PRIVATE $<INSTALL_INTERFACE:include>)
     target_include_directories(${test_name} PRIVATE $<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/include>)
     target_include_directories(${test_name} PRIVATE ${Caffe2_CPU_INCLUDE})
-    if(NOT MSVC)
-      target_compile_options(${test_name} PRIVATE -Wno-unused-variable)
-    endif()
     add_test(NAME ${test_name} COMMAND $<TARGET_FILE:${test_name}>)
     if(INSTALL_TEST)
       install(TARGETS ${test_name} DESTINATION test)

test/cpp/jit/CMakeLists.txt

@@ -129,9 +129,6 @@ endif(MSVC)
 
 target_link_libraries(test_jit PRIVATE ${JIT_TEST_DEPENDENCIES})
 target_include_directories(test_jit PRIVATE ${ATen_CPU_INCLUDE})
-if(NOT MSVC)
-  target_compile_options(test_jit PRIVATE $<$<COMPILE_LANGUAGE:CXX>:-Wno-unused-variable>)
-endif()
 
 if(LINUX)
   #Update to target_link_options when CMake version can be upgraded

test/cpp/tensorexpr/CMakeLists.txt

@@ -42,9 +42,6 @@ add_executable(test_tensorexpr
 target_link_libraries(test_tensorexpr PRIVATE torch gtest)
 target_include_directories(test_tensorexpr PRIVATE ${ATen_CPU_INCLUDE})
 target_compile_definitions(test_tensorexpr PRIVATE USE_GTEST)
-if(NOT MSVC)
-  target_compile_options(test_tensorexpr PRIVATE -Wno-unused-variable)
-endif()
 
 add_executable(tutorial_tensorexpr ${TENSOREXPR_TEST_ROOT}/tutorial.cpp)
 target_link_libraries(tutorial_tensorexpr PRIVATE torch)

test/cpp/tensorexpr/test_llvm.cpp

@@ -179,7 +179,7 @@ TEST(LLVM, CharToFloatCastTest) {
 }
 
 TEST(LLVM, BitCast) {
-  constexpr int16_t ref16 = 1337;
+  /* constexpr int16_t ref16 = 1337; */
   constexpr int32_t ref32 = 1337;
   constexpr int64_t ref64 = 1337;
   constexpr float reff32 = 1337.0f;
@@ -1395,7 +1395,6 @@ TEST(LLVM, EliminatedStmt) {
 TEST(LLVM, SimpleReduction) {
   int M = 128;
   int N = 64;
-  const int kTotalSize = M * N;
 
   BufHandle a("a", {1, M, N}, kFloat);
 
@@ -1429,7 +1428,6 @@ TEST(LLVM, SimpleReduction) {
 TEST(LLVM, RFactorReduction) {
   int M = 128;
   int N = 64;
-  const int kTotalSize = M * N;
 
   BufHandle a("a", {1, M, N}, kFloat);