@@ -219,8 +219,6 @@ TEST(
219
219
givenInvalidPtr_whenMoveAssigning_thenNewInstanceIsValid) {
220
220
intrusive_ptr<SomeClass> obj1 = make_intrusive<SomeClass>();
221
221
intrusive_ptr<SomeClass> obj2;
222
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
223
- SomeClass* obj1ptr = obj1.get ();
224
222
obj2 = std::move (obj1);
225
223
EXPECT_TRUE (obj2.defined ());
226
224
}
@@ -271,8 +269,6 @@ TEST(
271
269
givenInvalidPtr_whenMoveAssigningToBaseClass_thenNewInstanceIsValid) {
272
270
intrusive_ptr<SomeChildClass> obj1 = make_intrusive<SomeChildClass>(5 );
273
271
intrusive_ptr<SomeBaseClass> obj2;
274
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
275
- SomeBaseClass* obj1ptr = obj1.get ();
276
272
obj2 = std::move (obj1);
277
273
EXPECT_TRUE (obj2.defined ());
278
274
}
@@ -358,8 +354,6 @@ TEST(
358
354
givenInvalidPtr_whenCopyAssigning_thenNewInstanceIsValid) {
359
355
intrusive_ptr<SomeClass> obj1 = make_intrusive<SomeClass>();
360
356
intrusive_ptr<SomeClass> obj2;
361
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
362
- SomeClass* obj1ptr = obj1.get ();
363
357
obj2 = obj1;
364
358
EXPECT_TRUE (obj2.defined ());
365
359
}
@@ -387,8 +381,6 @@ TEST(
387
381
givenInvalidPtr_whenCopyAssigningToBaseClass_thenNewInstanceIsValid) {
388
382
intrusive_ptr<SomeChildClass> obj1 = make_intrusive<SomeChildClass>(5 );
389
383
intrusive_ptr<SomeBaseClass> obj2;
390
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
391
- SomeBaseClass* obj1ptr = obj1.get ();
392
384
obj2 = obj1;
393
385
EXPECT_TRUE (obj2.defined ());
394
386
}
@@ -1779,8 +1771,7 @@ TEST(
1779
1771
givenInvalidPtr_whenMoveAssigning_thenNewInstanceIsValid) {
1780
1772
IntrusiveAndWeak<SomeClass> obj1 = make_weak_intrusive<SomeClass>();
1781
1773
weak_intrusive_ptr<SomeClass> obj2 = make_invalid_weak<SomeClass>();
1782
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
1783
- SomeClass* obj1ptr = obj1.weak .lock ().get ();
1774
+ obj1.weak .lock ().get ();
1784
1775
obj2 = std::move (obj1.weak );
1785
1776
EXPECT_FALSE (obj2.expired ());
1786
1777
}
@@ -1826,8 +1817,7 @@ TEST(
1826
1817
givenWeakOnlyPtr_whenMoveAssigning_thenNewInstanceIsValid) {
1827
1818
IntrusiveAndWeak<SomeClass> obj1 = make_weak_intrusive<SomeClass>();
1828
1819
weak_intrusive_ptr<SomeClass> obj2 = make_weak_only<SomeClass>();
1829
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
1830
- SomeClass* obj1ptr = obj1.weak .lock ().get ();
1820
+ obj1.weak .lock ().get ();
1831
1821
obj2 = std::move (obj1.weak );
1832
1822
EXPECT_FALSE (obj2.expired ());
1833
1823
}
@@ -1846,8 +1836,7 @@ TEST(
1846
1836
WeakIntrusivePtrTest,
1847
1837
givenWeakOnlyPtr_whenMoveAssigningToSelf_thenStaysInvalid) {
1848
1838
weak_intrusive_ptr<SomeClass> obj1 = make_weak_only<SomeClass>();
1849
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
1850
- SomeClass* obj1ptr = obj1.lock ().get ();
1839
+ obj1.lock ().get ();
1851
1840
obj1 = std::move (obj1);
1852
1841
// NOLINTNEXTLINE(bugprone-use-after-move)
1853
1842
EXPECT_TRUE (obj1.expired ());
@@ -1911,8 +1900,7 @@ TEST(
1911
1900
IntrusiveAndWeak<SomeChildClass> obj1 =
1912
1901
make_weak_intrusive<SomeChildClass>(5 );
1913
1902
weak_intrusive_ptr<SomeBaseClass> obj2 = make_invalid_weak<SomeBaseClass>();
1914
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
1915
- SomeBaseClass* obj1ptr = obj1.weak .lock ().get ();
1903
+ obj1.weak .lock ().get ();
1916
1904
obj2 = std::move (obj1.weak );
1917
1905
EXPECT_FALSE (obj2.expired ());
1918
1906
}
@@ -1945,8 +1933,7 @@ TEST(
1945
1933
IntrusiveAndWeak<SomeChildClass> obj1 =
1946
1934
make_weak_intrusive<SomeChildClass>(5 );
1947
1935
weak_intrusive_ptr<SomeBaseClass> obj2 = make_weak_only<SomeBaseClass>(2 );
1948
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
1949
- SomeBaseClass* obj1ptr = obj1.weak .lock ().get ();
1936
+ obj1.weak .lock ().get ();
1950
1937
obj2 = std::move (obj1.weak );
1951
1938
EXPECT_FALSE (obj2.expired ());
1952
1939
}
@@ -2028,8 +2015,7 @@ TEST(
2028
2015
givenInvalidPtr_whenCopyAssigning_thenNewInstanceIsValid) {
2029
2016
IntrusiveAndWeak<SomeClass> obj1 = make_weak_intrusive<SomeClass>();
2030
2017
weak_intrusive_ptr<SomeClass> obj2 = make_invalid_weak<SomeClass>();
2031
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
2032
- SomeClass* obj1ptr = obj1.weak .lock ().get ();
2018
+ obj1.weak .lock ().get ();
2033
2019
obj2 = obj1.weak ;
2034
2020
EXPECT_FALSE (obj2.expired ());
2035
2021
}
@@ -2048,8 +2034,7 @@ TEST(
2048
2034
givenWeakOnlyPtr_whenCopyAssigning_thenNewInstanceIsValid) {
2049
2035
IntrusiveAndWeak<SomeClass> obj1 = make_weak_intrusive<SomeClass>();
2050
2036
weak_intrusive_ptr<SomeClass> obj2 = make_weak_only<SomeClass>();
2051
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
2052
- SomeClass* obj1ptr = obj1.weak .lock ().get ();
2037
+ obj1.weak .lock ().get ();
2053
2038
obj2 = obj1.weak ;
2054
2039
EXPECT_FALSE (obj2.expired ());
2055
2040
}
@@ -2068,8 +2053,7 @@ TEST(
2068
2053
WeakIntrusivePtrTest,
2069
2054
givenWeakOnlyPtr_whenCopyAssigningToSelf_thenStaysInvalid) {
2070
2055
weak_intrusive_ptr<SomeClass> obj1 = make_weak_only<SomeClass>();
2071
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
2072
- SomeClass* obj1ptr = obj1.lock ().get ();
2056
+ obj1.lock ().get ();
2073
2057
// NOLINTNEXTLINE(clang-diagnostic-self-assign-overloaded)
2074
2058
obj1 = obj1;
2075
2059
EXPECT_TRUE (obj1.expired ());
@@ -2111,8 +2095,7 @@ TEST(
2111
2095
IntrusiveAndWeak<SomeChildClass> obj1 =
2112
2096
make_weak_intrusive<SomeChildClass>(5 );
2113
2097
weak_intrusive_ptr<SomeBaseClass> obj2 = make_invalid_weak<SomeBaseClass>();
2114
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
2115
- SomeBaseClass* obj1ptr = obj1.weak .lock ().get ();
2098
+ obj1.weak .lock ().get ();
2116
2099
obj2 = obj1.weak ;
2117
2100
EXPECT_FALSE (obj2.expired ());
2118
2101
}
@@ -2145,8 +2128,7 @@ TEST(
2145
2128
IntrusiveAndWeak<SomeChildClass> obj1 =
2146
2129
make_weak_intrusive<SomeChildClass>(5 );
2147
2130
weak_intrusive_ptr<SomeBaseClass> obj2 = make_weak_only<SomeBaseClass>(2 );
2148
- // NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
2149
- SomeBaseClass* obj1ptr = obj1.weak .lock ().get ();
2131
+ obj1.weak .lock ().get ();
2150
2132
obj2 = obj1.weak ;
2151
2133
EXPECT_FALSE (obj2.expired ());
2152
2134
}
0 commit comments