-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments on PRs don't always trigger notifications #1977
Comments
Not getting notification if there is a comment with approve as well! (comment not included) |
+1 same here |
What i experienced for comment on PR, comment on PR review and comment on any commit outside PR. If I post 1 line comment, I receive notification always |
I am experiencing the same behavior. It's very annoying because one definitely wants to be notified about new comments in his own PR. Currently the comments are posted into respective PR thread in Slack but no notification is generated out of it so unless you are following the specific thread in Slack. Btw. where have you found the settings you have posted as a screenshot @loutPhilipps ? |
I'm also having this issue. I never get notifications for replies made under my review comments. cc @geramirez maybe? |
Describe the bug
After getting a comment on a PR I'm the author of, I don't receive any Slack notification, missing that I got a review. If the reviewer mentions me with a
@
, approves/requests changes, I do receive the notification consistently. This is with this setting on:To Reproduce
Doesn't seem to happen consistently.
Expected behavior
If I enable
Someone comments on your pull request
, I always receive a Slack notification, even if I'm not directly mentionedAdditional context
This issue has been present for a while (at least 3 years for me).
The text was updated successfully, but these errors were encountered: