-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft pull requests marked "Ready for Review" does not send notification #1975
Comments
I'm also seeing this happening intermittently. Last week we were getting notifications when we moved a draft pull request to Seeing this behavior right now. Creating a draft and then moving to |
We're also running into this. The following PR which was directly opened as a non-draft sent a slack notification as expected: dfinity/bitcoin-canister#369. However the following PR which was first opened as a draft then moved to This is happening in multiple of our repositories and it still worked 4 days ago. Also personal notifications still seem to work. |
we are also noticing this issue. |
Describe the bug
When a
Pull request
is created as aDraft pull request
then marked asReady for Review
, it does not send any notification to Slack anymore. This was working on 30 Oct.To Reproduce
Steps to reproduce the behavior:
Pull request
events in Slack:/github subscribe owner/repo pulls
Pull request
as draftReady for Review
Expected behavior
As it was working previously, I'm expecting the following notifications in Slack:
Pull request opened by ..
Pull request ready for review by ...
Review approved by ... on ... pull request
Pull request merged by ...
Additional context
Official integration between GitHub and Slack. Everything else is working, except the described scenario above.
The text was updated successfully, but these errors were encountered: