Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft pull requests marked "Ready for Review" does not send notification #1975

Open
phajnal-odevo opened this issue Nov 5, 2024 · 4 comments
Labels

Comments

@phajnal-odevo
Copy link

Describe the bug
When a Pull request is created as a Draft pull request then marked as Ready for Review, it does not send any notification to Slack anymore. This was working on 30 Oct.
To Reproduce
Steps to reproduce the behavior:

  1. Subscribe to Pull request events in Slack: /github subscribe owner/repo pulls
  2. Create a Pull request as draft
  3. Mark it as Ready for Review
  4. No notification

Expected behavior
As it was working previously, I'm expecting the following notifications in Slack:

  1. Pull request opened by ..
  2. Pull request ready for review by ...
  3. Review approved by ... on ... pull request
  4. Pull request merged by ...

Additional context
Official integration between GitHub and Slack. Everything else is working, except the described scenario above.

@snankani snankani removed their assignment Dec 3, 2024
@JoelYourstone
Copy link

image
I'm not sure how slack integrations are versioned, but this worked for me today.

However, it doesn't give you a preview of the PR in that event, what you see in the image is all we get. Also, we don't get notifications when a draft pull request is opened.

So when we are using a draft PR flow, we'll never get a rich preview of the PR in slack, compared to not using draft PRs. Not sure if that's a separate bug tho.

@cklewin
Copy link

cklewin commented Feb 18, 2025

I'm also seeing this happening intermittently. Last week we were getting notifications when we moved a draft pull request to Ready for Review, this week I'm seeing the same behavior as the OP.

Seeing this behavior right now. Creating a draft and then moving to Ready for Review doesn't post any notifications, otherwise we get the notification immediately when opening a non-draft pull request..

@basvandijk
Copy link

We're also running into this.

The following PR which was directly opened as a non-draft sent a slack notification as expected: dfinity/bitcoin-canister#369.

However the following PR which was first opened as a draft then moved to Ready for Review didn't sent any notification: dfinity/bitcoin-canister#370.

This is happening in multiple of our repositories and it still worked 4 days ago.

Also personal notifications still seem to work.

@kriscoleman
Copy link

we are also noticing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants