add some test

Author: inhere

composer.json

@@ -32,7 +32,7 @@
   },
   "autoload-dev": {
     "psr-4": {
-      "Inhere\\Console\\Test\\": "test/"
+      "Inhere\\ConsoleTest\\": "test/"
     }
   },
   "suggest": {

phpunit.xml.dist

@@ -8,7 +8,6 @@
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
          stopOnFailure="false"
-         syntaxCheck="false"
 >
     <testsuites>
         <testsuite name="Php Console Test Suite">

src/Application.php

@@ -39,7 +39,7 @@ public function controller(string $name, $class = null, $option = null)
 
         if (!$name || !$class) {
             Helper::throwInvalidArgument(
-                'Group-command "name" and "controller" not allowed to is empty! name: %s, controller: %s',
+                'Group-command "name" and "controller" cannot be empty! name: %s, controller: %s',
                 $name,
                 $class
             );

src/Base/AbstractApplication.php

@@ -56,6 +56,7 @@ abstract class AbstractApplication implements ApplicationInterface
         'updateAt' => '2017.03.24',
         'rootPath' => '',
         'hideRootPath' => true,
+
         // 'timeZone' => 'Asia/Shanghai',
         // 'env' => 'pdt', // dev test pdt
         // 'charset' => 'UTF-8',
@@ -153,7 +154,7 @@ protected function beforeRun()
      */
     public function run(bool $exit = true)
     {
-        $command = trim($this->input->getCommand(), $this->delimiter);
+        $command = \trim($this->input->getCommand(), $this->delimiter);
 
         $this->prepareRun();
         $this->filterSpecialCommand($command);
@@ -749,14 +750,22 @@ public function getName(): string
         return $this->meta['name'];
     }
 
+    /**
+     * @return string
+     */
+    public function getVersion(): string
+    {
+        return $this->meta['version'];
+    }
+
     /**
      * set meta info
      * @param array $meta
      */
     public function setMeta(array $meta)
     {
         if ($meta) {
-            $this->meta = array_merge($this->meta, $meta);
+            $this->meta = \array_merge($this->meta, $meta);
         }
     }
 
@@ -862,10 +871,6 @@ public function setCommandMetaValue(string $command, string $key, $value)
      */
     public function getCommandMetaValue(string $command, string $key, $default = null)
     {
-        if (isset($this->commandsMeta[$command][$key])) {
-            return $this->commandsMeta[$command][$key];
-        }
-
-        return $default;
+        return $this->commandsMeta[$command][$key] ?? $default;
     }
 }

test/ApplicationTest.php

@@ -1,27 +1,77 @@
 <?php
 
+namespace Inhere\ConsoleTest;
+
+use Inhere\Console\Application;
 use Inhere\Console\IO\InputInterface;
-use Inhere\Console\IO\OutputInterface;
 use PHPUnit\Framework\TestCase;
-use Inhere\Console\Application;
 
 /**
  * @covers Application
  */
 class ApplicationTest extends TestCase
 {
+    private function newApp()
+    {
+        return new Application([
+            'name'    => 'Tests',
+            'debug'   => 1,
+            'version' => '1.0.0',
+        ]);
+    }
+
     public function testApp()
     {
         $app = new Application([
-            'name' => 'Tests',
-            'debug' => 1,
+            'name'    => 'Tests',
+            'debug'   => 1,
             'version' => '1.0.0',
         ]);
 
         $this->assertArrayHasKey('name', $app->getMeta());
+        $this->assertEquals('Tests', $app->getName());
         $this->assertEquals('Tests', $app->getMeta('name'));
 
         $this->assertInstanceOf(InputInterface::class, $app->getInput());
-        $this->assertInstanceOf(OutputInterface::class, $app->getOutput());
+    }
+
+    public function testAddCommand()
+    {
+        $app = $this->newApp();
+
+        $app->addCommand('test', function (){
+            return 0;
+        });
+
+        $this->assertTrue($app->isCommand('test'));
+        $this->assertFalse($app->isController('test'));
+        $this->assertArrayHasKey('test', $app->getCommands());
+        $this->assertContains('test', $app->getCommandNames());
+    }
+
+    public function testAddController()
+    {
+        $app = $this->newApp();
+
+        $app->addGroup('test', TestController::class);
+
+        $this->assertTrue($app->isController('test'));
+        $this->assertFalse($app->isCommand('test'));
+        $this->assertArrayHasKey('test', $app->getControllers());
+        $this->assertContains('test', $app->getControllerNames());
+        $this->assertSame(TestController::class, $app->getControllers()['test']);
+    }
+
+    public function testAddControllerError()
+    {
+        $app = $this->newApp();
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessageRegExp('/"name" and "controller" cannot be empty/');
+        $app->addController('');
+
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessageRegExp('/"name" and "controller" cannot be empty/');
+        $app->controller('test', 'invalid');
     }
 }

test/CommandTest.php

@@ -1,5 +1,7 @@
 <?php
 
+namespace Inhere\ConsoleTest;
+
 use PHPUnit\Framework\TestCase;
 use Inhere\Console\Command;
 

test/ControllerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+namespace Inhere\ConsoleTest;
+
 use PHPUnit\Framework\TestCase;
 use Inhere\Console\Controller;
 

test/TestController.php

@@ -0,0 +1,30 @@
+<?php
+/**
+ * Created by PhpStorm.
+ * User: inhere
+ * Date: 2018-12-30
+ * Time: 18:58
+ */
+
+namespace Inhere\ConsoleTest;
+
+use Inhere\Console\Controller;
+
+/**
+ * Class TestController
+ * @package Inhere\ConsoleTest
+ */
+class TestController extends Controller
+{
+    protected static $name = 'test';
+    protected static $description = 'test description message';
+
+    /**
+     * this is an demo command in test
+     * @return int
+     */
+    public function demoCommand(): int
+    {
+        return 0;
+    }
+}

test/boot.php

@@ -14,8 +14,8 @@
         $path = str_replace('\\', '/', substr($class, strlen('Inhere\Console\Examples\\')));
         $file = dirname(__DIR__) . "/examples/{$path}.php";
 
-    } elseif (0 === strpos($class,'Inhere\Console\Test\\')) {
-        $path = str_replace('\\', '/', substr($class, strlen('Inhere\Console\Test\\')));
+    } elseif (0 === strpos($class,'Inhere\ConsoleTest\\')) {
+        $path = str_replace('\\', '/', substr($class, strlen('Inhere\ConsoleTest\\')));
         $file = __DIR__ . "/{$path}.php";
     } elseif (0 === strpos($class,'Inhere\Console\\')) {
         $path = str_replace('\\', '/', substr($class, strlen('Inhere\Console\\')));