Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

montgomery representation #16

Closed
TalDerei opened this issue Mar 13, 2023 · 2 comments
Closed

montgomery representation #16

TalDerei opened this issue Mar 13, 2023 · 2 comments
Labels

Comments

@TalDerei
Copy link

https://github.com/ingonyama-zk/icicle/blob/00231723b9fe0e2d7cbfc3202109cd6399b4c523/icicle/curves/bls12_381.cuh#LL27C41-L27C44

This is usually represented as the montgomery form of 1 if you want to convert to between affine/jacobian/projective forms: https://github.com/ingonyama-zk/icicle/blob/main/icicle/primitives/projective.cuh#L23

@DmytroTym
Copy link
Contributor

DmytroTym commented Mar 17, 2023

This has to do with the answer to the previous issue you opened, namely that we currently don't use Montgomery multiplication. If we succeed in having competitive non-Montgomery multiplier, the config file can stay the way it is. If we don't and we have to move to Montgomery, then you're right, one needs to be one in Montgomery form, and not just plain 1.

@DmytroTym
Copy link
Contributor

I feel like this can be closed due to #289
We are on par with the state-of-the art Montgomery multiplier so it feels like there's no urgency to move to it. Can be reopened if people improve Montgomery multiplication or we just decide to support Montgomery as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants