Skip to content

Commit ef8beb8

Browse files
committed
remove some
1 parent 0886213 commit ef8beb8

File tree

4 files changed

+1
-9
lines changed

4 files changed

+1
-9
lines changed

.github/workflows/dev-pr.yml

-4
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,6 @@ jobs:
7070
run: |
7171
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/goicicle
7272
go test ./goicicle/curves/bn254 -count=1
73-
# TODO: Fix tests for bls12377
74-
# TODO: Fix tests for bls12381
75-
# run: go test ./goicicle/curves/bn254 ./goicicle/curves/bls12377 ./goicicle/curves/bls12381 -count=1
7673
7774
formatting-golang:
7875
name: Check Golang Code Formatting
@@ -83,7 +80,6 @@ jobs:
8380
- name: Check gofmt
8481
run: if [[ $(go list ./... | xargs go fmt) ]]; then echo "Please run go fmt"; exit 1; fi
8582

86-
# TODO: Add once Golang make file supports building for Windows
8783
# build-golang-windows:
8884
# name: Build Golang on Windows
8985
# runs-on: windows-2022

.github/workflows/main-build.yml

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ jobs:
4545
run: make all
4646
working-directory: ./goicicle
4747

48-
# TODO: Add once Golang make file supports building for Windows
4948
# build-golang-windows:
5049
# name: Build Golang on Windows
5150
# runs-on: windows-2022

.github/workflows/main-test.yml

-3
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,3 @@ jobs:
3232
run: |
3333
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/goicicle
3434
go test ./goicicle/curves/bn254 -count=1
35-
# TODO: Fix tests for bls12377
36-
# TODO: Fix tests for bls12381
37-
# run: go test ./goicicle/curves/bn254 ./goicicle/curves/bls12377 ./goicicle/curves/bls12381 -count=1

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ rustacuda = "0.1"
3535
rustacuda_core = "0.1"
3636
rustacuda_derive = "0.1"
3737

38-
rand = "*" #TODO: move rand and ark dependencies to dev once random scalar/point generation is done "natively"
38+
rand = "*"
3939

4040
[build-dependencies]
4141
cc = { version = "1.0", features = ["parallel"] }

0 commit comments

Comments
 (0)