fix sumcheck transcript-config copied instead of moved

Author: yshekel

icicle/backend/cpu/include/cpu_sumcheck.h

@@ -22,7 +22,7 @@ namespace icicle {
       const uint64_t mle_polynomial_size,
       const F& claimed_sum,
       const CombineFunction<F>& combine_function,
-      const SumcheckTranscriptConfig<F>&& transcript_config,
+      SumcheckTranscriptConfig<F>&& transcript_config,
       const SumcheckConfig& sumcheck_config,
       SumcheckProof<F>& sumcheck_proof /*out*/) override
     {

icicle/include/icicle/backend/sumcheck_backend.h

@@ -49,7 +49,7 @@ namespace icicle {
       const uint64_t mle_polynomial_size,
       const F& claimed_sum,
       const CombineFunction<F>& combine_function,
-      const SumcheckTranscriptConfig<F>&& transcript_config,
+      SumcheckTranscriptConfig<F>&& transcript_config,
       const SumcheckConfig& sumcheck_config,
       SumcheckProof<F>& sumcheck_proof /*out*/) = 0;
   };

icicle/include/icicle/sumcheck/sumcheck.h

@@ -57,7 +57,7 @@ namespace icicle {
       const uint64_t mle_polynomial_size,
       const F& claimed_sum,
       const CombineFunction<F>& combine_function,
-      const SumcheckTranscriptConfig<F>&& transcript_config,
+      SumcheckTranscriptConfig<F>&& transcript_config,
       const SumcheckConfig& sumcheck_config,
       SumcheckProof<F>& sumcheck_proof /*out*/) const
     {
@@ -77,7 +77,7 @@ namespace icicle {
     eIcicleError verify(
       const SumcheckProof<F>& sumcheck_proof,
       const F& claimed_sum,
-      const SumcheckTranscriptConfig<F>&& transcript_config,
+      SumcheckTranscriptConfig<F>&& transcript_config,
       bool& valid /*out*/)
     {
       valid = false;

icicle/include/icicle/sumcheck/sumcheck_transcript.h

@@ -10,7 +10,7 @@ class SumcheckTranscript
     const S& claimed_sum,
     const uint32_t mle_polynomial_size,
     const uint32_t combine_function_poly_degree,
-    const SumcheckTranscriptConfig<S>&& transcript_config)
+    SumcheckTranscriptConfig<S>&& transcript_config)
       : m_claimed_sum(claimed_sum), m_mle_polynomial_size(mle_polynomial_size),
         m_combine_function_poly_degree(combine_function_poly_degree), m_transcript_config(std::move(transcript_config))
   {
@@ -40,7 +40,7 @@ class SumcheckTranscript
   }
 
 private:
-  const SumcheckTranscriptConfig<S>&& m_transcript_config; // configuration how to build the transcript
+  const SumcheckTranscriptConfig<S> m_transcript_config; // configuration how to build the transcript
   HashConfig m_config;                                     // hash config - default
   uint32_t m_round_idx;                                    //
   std::vector<std::byte> m_entry_0;                        //

icicle/include/icicle/sumcheck/sumcheck_transcript_config.h

@@ -82,7 +82,7 @@ namespace icicle {
 
     // Move Constructor
     SumcheckTranscriptConfig(SumcheckTranscriptConfig&& other) noexcept
-        : m_hasher(other.m_hasher), m_domain_separator_label(std::move(other.m_domain_separator_label)),
+        : m_hasher(std::move(other.m_hasher)), m_domain_separator_label(std::move(other.m_domain_separator_label)),
           m_round_poly_label(std::move(other.m_round_poly_label)),
           m_round_challenge_label(std::move(other.m_round_challenge_label)), m_little_endian(other.m_little_endian),
           m_seed_rng(other.m_seed_rng)

icicle/tests/test_field_api.cpp

@@ -184,11 +184,12 @@ TEST_F(FieldTestBase, Sumcheck)
     END_TIMER(sumcheck, oss.str().c_str(), true);
 
     // ===== Verifier side ======
+    SumcheckTranscriptConfig<scalar_t> verifier_transcript_config; // default configuration
     // create sumcheck
     auto verifier_sumcheck = create_sumcheck<scalar_t>();
     bool verification_pass = false;
     ICICLE_CHECK(
-      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(transcript_config), verification_pass));
+      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(verifier_transcript_config), verification_pass));
 
     ASSERT_EQ(true, verification_pass);
   };
@@ -257,10 +258,11 @@ TEST_F(FieldTestBase, SumcheckDataOnDevice)
   END_TIMER(sumcheck, oss.str().c_str(), true);
 
   // ===== Verifier side ======
+  SumcheckTranscriptConfig<scalar_t> verifier_transcript_config; // default configuration
   // create sumcheck
   auto verifier_sumcheck = create_sumcheck<scalar_t>();
   bool verification_pass = false;
-  ICICLE_CHECK(verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(transcript_config), verification_pass));
+  ICICLE_CHECK(verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(verifier_transcript_config), verification_pass));
 
   ASSERT_EQ(true, verification_pass);
 
@@ -327,11 +329,12 @@ TEST_F(FieldTestBase, SumcheckUserDefinedCombine)
     END_TIMER(sumcheck, oss.str().c_str(), true);
 
     // ===== Verifier side ======
+    SumcheckTranscriptConfig<scalar_t> verifier_transcript_config; // default configuration
     // create sumcheck
     auto verifier_sumcheck = create_sumcheck<scalar_t>();
     bool verification_pass = false;
     ICICLE_CHECK(
-      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(transcript_config), verification_pass));
+      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(verifier_transcript_config), verification_pass));
 
     ASSERT_EQ(true, verification_pass);
   };
@@ -492,11 +495,12 @@ TEST_F(FieldTestBase, SumcheckIdentity)
     END_TIMER(sumcheck, oss.str().c_str(), true);
 
     // ===== Verifier side ======
+    SumcheckTranscriptConfig<scalar_t> verifier_transcript_config; // default configuration
     // create sumcheck
     auto verifier_sumcheck = create_sumcheck<scalar_t>();
     bool verification_pass = false;
     ICICLE_CHECK(
-      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(transcript_config), verification_pass));
+      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(verifier_transcript_config), verification_pass));
 
     ASSERT_EQ(true, verification_pass);
   };
@@ -557,11 +561,12 @@ TEST_F(FieldTestBase, SumcheckSingleInputProgram)
     END_TIMER(sumcheck, oss.str().c_str(), true);
 
     // ===== Verifier side ======
+    SumcheckTranscriptConfig<scalar_t> verifier_transcript_config; // default configuration
     // create sumcheck
     auto verifier_sumcheck = create_sumcheck<scalar_t>();
     bool verification_pass = false;
     ICICLE_CHECK(
-      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(transcript_config), verification_pass));
+      verifier_sumcheck.verify(sumcheck_proof, claimed_sum, std::move(verifier_transcript_config), verification_pass));
 
     ASSERT_EQ(true, verification_pass);
   };