[IMP] academic: boolean to require student in invoices

X-original-commit: 1a16c36

Author: lef-adhoc

academic/i18n/es.po

@@ -1200,7 +1200,7 @@ msgstr "Año"
 #. odoo-python
 #: code:addons/academic/models/academic_group.py:0
 msgid "Year: %s"
-msgstr ""
+msgstr "Año: %s"
 
 #. module: academic
 #. odoo-python
@@ -1288,3 +1288,27 @@ msgstr "asignatura"
 #: model:ir.model.fields,help:academic.field_res_users__disabled_person
 msgid "¿Alumno/a con Dificultades de aprendizaje?"
 msgstr ""
+
+#. module: academic
+#: model:ir.model.fields,field_description:academic.field_account_bank_statement_line__require_student_on_invoices
+#: model:ir.model.fields,field_description:academic.field_account_move__require_student_on_invoices
+#: model:ir.model.fields,field_description:academic.field_account_payment__require_student_on_invoices
+#: model:ir.model.fields,field_description:academic.field_res_company__require_student_on_invoices
+msgid "Require Student On Invoices"
+msgstr "Requerir Estudiantes en Facturas"
+
+#. module: academic
+#: model_terms:ir.ui.view,arch_db:academic.academic_view_move_form
+msgid "Warning: This invoice is not associated with any student"
+msgstr "Precaución: Esta factura no está asociada a ningún estudiante"
+
+#. module: academic
+#. odoo-python
+#: code:addons/academic/models/res_company.py:0
+#, python-format
+msgid ""
+"You cannot mark require student on invoices if there are already invoices "
+"without students."
+msgstr ""
+"No puedes marcar 'requerir estudiante' en las facturas si ya existen facturas "
+"sin estudiantes."

academic/models/account_move.py

@@ -10,23 +10,27 @@ class AccountMove(models.Model):
     student_id = fields.Many2one(
         "res.partner", domain="[('id', 'in', student_ids), ('partner_type', '=', 'student')]", index=True
     )
+    require_student_on_invoices = fields.Boolean(related="company_id.require_student_on_invoices")
 
     @api.constrains("student_id", "move_type")
     def _check_student(self):
         # Está saltando warning en runbot por esta constrains ya que hay facturas sin estudiante, por lo tanto
         # desactivamos el chequeo cuando se hace la instalación
         if self.env.context.get("install_mode"):
             return True
-        invoices_wo_student = self.filtered(lambda x: x.move_type in ["out_invoice", "out_refund"] and not x.student_id)
-        if invoices_wo_student:
-            msg = self.env._("Las facturas de clientes y notas de debito debe tener asociado siempre un alumno.")
-            if len(invoices_wo_student) > 1:
-                msg += (
-                    ".\n"
-                    + self.env._("Los siguientes documentos no cumplen esa condición:")
-                    + "\n\n - %s" % "\n - ".join(invoices_wo_student.mapped("display_name"))
-                )
-            raise ValidationError(msg)
+        if self.filtered("require_student_on_invoices"):
+            invoices_wo_student = self.filtered(
+                lambda x: x.move_type in ["out_invoice", "out_refund"] and not x.student_id
+            )
+            if invoices_wo_student:
+                msg = self.env._("Las facturas de clientes y notas de debito debe tener asociado siempre un alumno.")
+                if len(invoices_wo_student) > 1:
+                    msg += (
+                        ".\n"
+                        + self.env._("Los siguientes documentos no cumplen esa condición:")
+                        + "\n\n - %s" % "\n - ".join(invoices_wo_student.mapped("display_name"))
+                    )
+                raise ValidationError(msg)
 
     @api.depends("partner_id")
     def _compute_student_ids(self):

academic/models/res_company.py

@@ -2,7 +2,8 @@
 # For copyright and license notices, see __manifest__.py file in module root
 # directory
 ##############################################################################
-from odoo import fields, models
+from odoo import api, fields, models
+from odoo.exceptions import UserError
 
 
 class ResCompany(models.Model):
@@ -15,3 +16,23 @@ class ResCompany(models.Model):
     )
     study_plan_id = fields.Many2one(comodel_name="academic.study.plan", string="Plan de Estudio")
     family_required = fields.Boolean()
+    require_student_on_invoices = fields.Boolean(default=True)
+
+    @api.constrains("require_student_on_invoices")
+    def _check_invoices_with_student(self):
+        cia_require_students = self.filtered("require_student_on_invoices")
+        if cia_require_students:
+            invoices = self.env["account.move"].search(
+                [
+                    ("company_id", "in", cia_require_students.ids),
+                    ("move_type", "in", ["out_invoice", "out_refund"]),
+                    ("student_id", "=", False),
+                ],
+                limit=1,
+            )
+            if invoices:
+                raise UserError(
+                    self.env._(
+                        "You cannot mark require student on invoices if there are already invoices without students."
+                    )
+                )

academic/views/account_move_views.xml

@@ -24,6 +24,12 @@
             <field name="partner_shipping_id" position="attributes">
                 <attribute name="invisible">1</attribute>
             </field>
+            <xpath expr="//sheet" position="before">
+                <field name="require_student_on_invoices" invisible="1"/>
+                <div class="alert alert-warning oe_edit_only" role="alert" invisible="student_id or not require_student_on_invoices">
+                  Warning: This invoice is not associated with any student
+                </div>
+            </xpath>
         </field>
     </record>
     <record id="academic_view_account_invoice_filter" model="ir.ui.view">

academic/views/res_company_views.xml

@@ -34,6 +34,7 @@
             <div class="o_address_format"  position='after'>
                 <field name="study_plan_id"/>
                 <field name="family_required"/>
+                <field name="require_student_on_invoices"/>
             </div>
         </field>
     </record>