Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gridfs-stream dependency #157

Closed
make-github-pseudonymous-again opened this issue Jan 14, 2021 · 5 comments
Closed

Remove gridfs-stream dependency #157

make-github-pseudonymous-again opened this issue Jan 14, 2021 · 5 comments
Labels
priority This issue needs fixing ASAP
Milestone
Public release

Comments

@make-github-pseudonymous-again
Copy link
Contributor

The last release of dependency gridfs-stream was six years ago!
Meteor-Files (ostrio:files) can now be used without gridfs-stream as shown in this GridFS demo.
Related to #33.
@make-github-pseudonymous-again make-github-pseudonymous-again added priority This issue needs fixing ASAP bug Something isn't working labels Jan 14, 2021
@make-github-pseudonymous-again
Copy link
Contributor Author

The docs.

@make-github-pseudonymous-again
Copy link
Contributor Author

Not a bug. #33 was caused by something else. Moreover a dependency upgrade is not needed to do the move.

@make-github-pseudonymous-again make-github-pseudonymous-again removed the bug Something isn't working label Jan 26, 2021
@make-github-pseudonymous-again
Copy link
Contributor Author

Plus gridfs-stream relies on deprecated GridStore. See API docs here.

@make-github-pseudonymous-again
Copy link
Contributor Author

make-github-pseudonymous-again commented Jun 18, 2021 •
edited
Loading

Note that gridfs-stream was using fs as the default name for bucket. Either via GridStore or as a constant. Because of that, current deployment uses fs as bucket name. The new GridFSBucket API uses the same default. However, moving forward it is probably best to explicitly set this in our files.

@make-github-pseudonymous-again
Copy link
Contributor Author

make-github-pseudonymous-again commented Jun 18, 2021 •
edited
Loading

Note: I followed this particular version of the docs https://github.com/veliovgroup/Meteor-Files/blob/6a192b74537c705069ad60b21959ef2233b9f58b/docs/gridfs-bucket-integration.md

Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority This issue needs fixing ASAP
Projects
None yet
Milestone
Public release
Development

No branches or pull requests
1 participant
@make-github-pseudonymous-again