Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lux usage in luxletterlink to signal #94

Open
georgringer opened this issue Aug 29, 2021 · 1 comment
Open

Move lux usage in luxletterlink to signal #94

georgringer opened this issue Aug 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@georgringer
Copy link
Contributor

georgringer commented Aug 29, 2021

The LuxletterLink used ext lux. Even though there is a guard clause to check if the extension is installed, the code should be moved to the signal right above.

protected function luxIdentification(Link $link): void
    {
        $identification = true;
        $this->signalDispatch(__CLASS__, __FUNCTION__, [&$identification, $link]);
        if (ExtensionUtility::isLuxAvailable('7.0.0') && $identification === true) {
            CookieUtility::setCookie('luxletterlinkhash', $link->getHash());
        }
    }
@einpraegsam
Copy link
Collaborator

Yes, would be a bit cleaner. I let this ticket open as a reminder for me.

@einpraegsam einpraegsam added the enhancement New feature or request label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants