Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: only show "(x = Small files)" legend when there are small files on the screen #15

Closed
imsnif opened this issue Jun 17, 2020 · 2 comments · Fixed by #75
Closed

Feature: only show "(x = Small files)" legend when there are small files on the screen #15

imsnif opened this issue Jun 17, 2020 · 2 comments · Fixed by #75
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@imsnif
Copy link
Owner

imsnif commented Jun 17, 2020

Otherwise it might be a little confusing...
@imsnif imsnif added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 17, 2020
@imsnif imsnif mentioned this issue Jul 7, 2020
Open
@pjsier
Copy link
Contributor

pjsier commented Oct 2, 2020

@imsnif I'm interested in taking this on. From a quick look I'm thinking about adding hide_small_files_legend bool field to BottomLine and setting it based on whether unrenderable_tile_coordinates on Board is None similar to how hide_delete is working. Then we could avoid subtracting the small files length from the output line if it isn't needed. Let me know if I'm missing anything, thanks!

@imsnif
Copy link
Owner Author

imsnif commented Oct 2, 2020

Cool - sounds like a good direction. There is an edge case described in more detail here: #62, but that's probably out of scope for this issue.

@pjsier pjsier mentioned this issue Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: only show small files legend when visible pjsier/diskonaut
2 participants
@imsnif @pjsier