-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with Photos page in Edge Chromium and Firefox #17107
Comments
Have you tried using incognito mode to see if any potential extension could be the cause? I cannot reproduce it on my end on Chrome, Firefox and Safari |
Hi @alextran1502. Yes, I've just tested it on Edge with all extensions disabled, but I still get the same behaviour, which I guess is coherent with the fact that I did not have any JS errors in my devtools console. When I've tried before opening this issue with Firefox, it worked almost every time. I'm writing almost and not always, because it happened that between a reload and another, it broke in the same way as it does on Edge. I'm not sure what changed in the JS code Immich uses to render the Photos page, but I've also just tested that changing the |
Same error on version 1.130.1. using Chrome 134.0.6998.178 |
Update: if I use TAB key and move selection to any photo and press enter it will open normally. It looks like some onclick is missing. |
It is very strange that I still can't reproduce this issue on the demo instance, as stated in the issue description. I tried the exact version on Edge Do you have the steps to reproduce it exactly? or a screencapture? |
Cookies, local storage and session storage cleared. There are no errors in browser console. No missing resources (downloaded files), all have code 200. No errors in docker logs. Steps to reproduce:
|
Hi @knechtandreas, do you think this is related to the focus changes? FWIW, I still can't reproduce this behavior at all on my end, on the demo instance from all browsers that I have access to Chrome/Firefox/Safari/Edge on both Mac and Windows. |
I'll take a look in about 2 hours when I'm back home and near computer. Don't think it would be related but not 100% sure. |
So I just tried this on MacOS with latest version of Firefox and Edge Version Which exact operating system are you running? Unlikely, but could it be Intel vs ARM perhaps? |
Same here, Chrome, Edge, Firefox same issue, no picture open after click |
I was testing on an amd64 build of Windows 11 (24H2), but I don't think this has any effect on this kind of things... could it be some sort of race condition, somewhere? Maybe in the piece of code that computes image sizes before rendering them? @knechtandreas if you want to take another look at it, you could follow the steps written at the beginning of this thread, while having developer tools opened and CPU throttling enabled. Usually this helps in reproducing these kind of errors, if it's really a race condition. I'm using a Ryzen 7 3700x, so it's not anymore (and probably it has never been) the fastest CPU on the market. If you are on Apple Silicon, you might need to throttle CPU by a large factor. In a about a couple of hours I'll be able to test all of this also by myself on a Mac (M1 Pro). I'll keep you posted |
Update: I've tried it on my Mac, but I wasn't able to reproduce the issue, even with CPU throttling enabled. I might take another look at it this evening when I'm back to my computer |
no response on click too. |
@l0ll098 @csrednicki Can you try this instance and see if you can click on the assets? https://pr-17139.preview.internal.immich.cloud/auth/login email: [email protected] |
@alextran1502 Tried it, same issue as in my selfhosted, no picture after klick........ |
@Sunny99999999 Do you mind performing a screenrecording on your machine to demonstrate it? |
I tested this on Mac Mini M4 on Chrome and Safari and it worked without any issue. Then I tested it on Windows where error occured. Here's my screen recording. When you see blue outline around image it means I clicked immich-compressed.mp4 |
@csrednicki I think I know where the issue is, somehow it gets into the touch screen mode |
Can you help with going to this website and capturing a screenshot of the page? https://patrickhlauke.github.io/touch/pointer-hover-any-pointer-any-hover/ Also, it would be good to know what the actual hardware devices are that are causing this issue. |
this |
@csrednicki, can you help confirm whether this instance fixes the issue? https://pr-17144.preview.internal.immich.cloud/ email: [email protected] |
still not working |
@csrednicki So if you use the keyboard/mouse with the edge, it doesn't work. But I assume it works if you touch it with your finger? |
I have external monitor, mouse and keyboard connected to surface dock. Using it that way is producing this error. I now used surface screen and touching image actually opened image. I also observed that I had to tap multiple times to open some images. Some opened in first try. Some after 5 taps. |
@alextran1502 I've tested the second instance you linked, as the first one was no longer accessible. I've tried it with my installation of Edge and I can confirm that it does seem to be working: I can click on images to view them in fullscreen and I see the timeline on the right. However, I don't know if this really fixes the issue, as I might have been lucky (for example tests made by @csrednicki seem to have been less successful). If it does help, I'm not on a prebuilt PC, so there's not a specifc model number. However, my 2560x1440p screen is definitely not a touch screen, so my only input methods are a regular keyboard and a mouse. Here's a screenshot of this website you linked before (running on the same PC, same monitor and same browser I was using when I firstly encountered this issue). If you think a recording produced by the Performance tab of my devtools (captured from the demo website) can help you in debugging the root cause, I can share it with you. |
@l0ll098 Thanks for the report. I think there are some caveats in detecting touch devices, which is causing the issue. The demo instance is using the release version, which doesn't have the fix that you see in the test instance above. Is there any accessibility settings on your PC? |
@alextran1502 no, all accessibility settings are disabled and even Windows says that my screen does not support touch/pen inputs. I've also just checked again the website that prints out which type of pointer your device supports, and now when I check it out using my installation of Edge (the same I've been using in the last two days), it shows the same pieces of information that both Chrome and Firefox were reporting. Seeing this I've also reloaded the demo instance, and I can click images to see them in fullscreen and timeline is visible, even though that instance still does not include the unmerged fix. At this point I'm a bit confused, it seems like Edge sometimes messes things up, and when it happens, the current release of Immich has some hard times as a result 😕 I guess that the PR linked to this issue could still make sense for devices with touch screens, and for weird cases such as this. Is there something else you want me to test/verify? |
I'm experiencing the same problem on my Fedora workstation using the official Chrome browser, Version 134.0.6998.165 (Official Build) (64-bit). The issue occurs only when I access the Immich server locally from the same system using Chrome. However, when I use the same version and build of Chrome to connect to the Immich server remotely, everything functions properly. The hardware is a Dell desktop. No touch screen. I experienced the same issue on https://demo.immich.app/photos but it works on https://pr-17144.preview.internal.immich.cloud. |
it works on https://pr-17144.preview.internal.immich.cloud/ |
Same issue here. Chrome 134.0.6998.167 / Dell Windows Laptop, immich v1.130.2. Incognito/privacy mode. Neither the preview system nor my own system works. Also happens for both systems with Firefox 136.0.3 privacy mode. |
I have searched the existing issues, both open and closed, to make sure this is not a duplicate report.
The bug
Hi, with the 1.130.0 update and the underlying changes to the UI of the
/photos
page, users on Chromium-based Edge can't click on images to view them in full screen. Indeed, clicking on an image does nothing. Weirdly, sometimes this also happens with Firefox, while other times it's fine.When this issue occurs, you can see that the timeline in the lateral scrollbar does no longer show up, even though it's present in the DOM. Furthermore, visiting the
/photos?at=<image_uuid>
page does not trigger the scroll of the gallery to the appropriate image.This happens consistently in Chromium-based Edge, and sometimes with Firefox. Chrome seems to not be affected by these issues. I don't know about Safari, as at this moment I don't have my Mac on hand to test it.
Before the 1.130.0 update, for example up to the 1.129.0 release, this issue was not observable in any browser, or at least not in Edge.
This happens both with my installation (updated from 1.129.0) and with the demo website.
As you can see in this screenshot took in Edge, we don't see the timeline on the right hand side.
Whereas, this is what Chrome renders. Here we can see the timeline on the right and, if I click on an image, I'm redirected to the
/images/<image_uuid>
page.Also, I don't see any error in neither the Console nor in the Network tab of those browsers' DevTools.
I've tested this with these browsers and versions:
The OS that Immich Server is running on
N/A
Version of Immich Server
1.130.0
Version of Immich Mobile App
N/A
Platform with the issue
Your docker-compose.yml content
N/A, it happens also with the demo website
Your .env content
Reproduction steps
Relevant log output
Additional information
No response
The text was updated successfully, but these errors were encountered: