From 1929a8d7b6d6ed733844944982be358d05967231 Mon Sep 17 00:00:00 2001 From: Deepika Upadhyay Date: Mon, 20 Feb 2023 17:39:38 +0530 Subject: [PATCH] ci: timeout-minutes has a known issue with composite use timeout for the step in main workflow instead https://github.com/actions/runner/issues/1979 https://github.com/metabase/metabase/pull/24554/files once support for timeout-minutes is added we can remove these steps Signed-off-by: Deepika Upadhyay --- .github/workflows/build.yml | 3 +++ .github/workflows/canary-integration-test.yml | 19 +++++++++++++++++++ .../integration-test-helm-suite.yaml | 1 + .../workflows/integration-test-mgr-suite.yaml | 1 + .../integration-test-multi-cluster-suite.yaml | 1 + .../integration-test-object-suite.yaml | 1 + .../integration-test-smoke-suite.yaml | 1 + .../integration-test-upgrade-suite.yaml | 1 + .github/workflows/push-build.yaml | 1 + .github/workflows/tmate_debug/action.yml | 12 +++++++++--- 10 files changed, 38 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b8b4e511636d..85c34d89f803 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -66,6 +66,8 @@ jobs: run: tests/scripts/validate_modified_files.sh gen-rbac - name: consider debugging + if: failure() + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug linux-build-all: @@ -97,4 +99,5 @@ jobs: - name: consider debugging if: failure() + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/canary-integration-test.yml b/.github/workflows/canary-integration-test.yml index d0eb11dd59ef..0f171b3f3378 100644 --- a/.github/workflows/canary-integration-test.yml +++ b/.github/workflows/canary-integration-test.yml @@ -204,6 +204,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug raw-disk: @@ -255,6 +256,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug two-osds-in-device: @@ -300,6 +302,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug osd-with-metadata-device: @@ -351,6 +354,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug encryption: @@ -447,6 +451,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug pvc: @@ -518,6 +523,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug pvc-db: @@ -565,6 +571,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug pvc-db-wal: @@ -615,6 +622,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug encryption-pvc: @@ -682,6 +690,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug encryption-pvc-db: @@ -731,6 +740,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug encryption-pvc-db-wal: @@ -781,6 +791,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug encryption-pvc-kms-vault-token-auth: @@ -859,6 +870,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug encryption-pvc-kms-vault-k8s-auth: @@ -919,6 +931,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug lvm-pvc: @@ -971,6 +984,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug multi-cluster-mirroring: @@ -1219,6 +1233,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug rgw-multisite-testing: @@ -1245,6 +1260,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug encryption-pvc-kms-ibm-kp: @@ -1274,6 +1290,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug multus-cluster-network: @@ -1353,6 +1370,7 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug csi-hostnetwork-disabled: @@ -1403,4 +1421,5 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/integration-test-helm-suite.yaml b/.github/workflows/integration-test-helm-suite.yaml index 48ceb58b157e..1440ede522cc 100644 --- a/.github/workflows/integration-test-helm-suite.yaml +++ b/.github/workflows/integration-test-helm-suite.yaml @@ -63,4 +63,5 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/integration-test-mgr-suite.yaml b/.github/workflows/integration-test-mgr-suite.yaml index 554d7d5b4939..5f7b3c2f21e7 100644 --- a/.github/workflows/integration-test-mgr-suite.yaml +++ b/.github/workflows/integration-test-mgr-suite.yaml @@ -57,4 +57,5 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/integration-test-multi-cluster-suite.yaml b/.github/workflows/integration-test-multi-cluster-suite.yaml index 0274446a905c..7f605fbcb78b 100644 --- a/.github/workflows/integration-test-multi-cluster-suite.yaml +++ b/.github/workflows/integration-test-multi-cluster-suite.yaml @@ -59,4 +59,5 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/integration-test-object-suite.yaml b/.github/workflows/integration-test-object-suite.yaml index 1bc4a9f26dd7..ed71ec57e944 100644 --- a/.github/workflows/integration-test-object-suite.yaml +++ b/.github/workflows/integration-test-object-suite.yaml @@ -58,4 +58,5 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/integration-test-smoke-suite.yaml b/.github/workflows/integration-test-smoke-suite.yaml index 33cbcc139949..fcf829aa8983 100644 --- a/.github/workflows/integration-test-smoke-suite.yaml +++ b/.github/workflows/integration-test-smoke-suite.yaml @@ -58,4 +58,5 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/integration-test-upgrade-suite.yaml b/.github/workflows/integration-test-upgrade-suite.yaml index 69ecfcf989cd..3441da16e91f 100644 --- a/.github/workflows/integration-test-upgrade-suite.yaml +++ b/.github/workflows/integration-test-upgrade-suite.yaml @@ -106,4 +106,5 @@ jobs: - name: consider debugging if: failure() && github.event_name == 'pull_request' + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/push-build.yaml b/.github/workflows/push-build.yaml index c955b303824c..057bf7ea63ee 100644 --- a/.github/workflows/push-build.yaml +++ b/.github/workflows/push-build.yaml @@ -78,4 +78,5 @@ jobs: - name: consider debugging if: failure() + timeout-minutes: 60 uses: ./.github/workflows/tmate_debug diff --git a/.github/workflows/tmate_debug/action.yml b/.github/workflows/tmate_debug/action.yml index 44c4f897604a..bf63e0c79f14 100644 --- a/.github/workflows/tmate_debug/action.yml +++ b/.github/workflows/tmate_debug/action.yml @@ -1,18 +1,24 @@ name: "Tmate debugging tests" description: "Setup tmate session if the test fails" +<<<<<<< HEAD # ...name, description and inputs as above +======= +inputs: + use-tmate: + description: "boolean for enabling TMATE" + required: true +>>>>>>> fef11fa6a (ci: timeout-minutes has a known issue with composite) runs: using: "composite" steps: - name: consider debugging shell: bash --noprofile --norc -eo pipefail -x {0} - if: failure() && github.event_name == 'pull_request' run: | # Enable tmate only in the Rook fork, where the USE_TMATE secret is set in the repo, or if the action is re-run if [ "$GITHUB_REPOSITORY_OWNER" = "koor-tech" ] || [ -n "${{ secrets.USE_TMATE }}" ] || [ "$GITHUB_RUN_ATTEMPT" -gt 1 ]; then echo USE_TMATE=1 >> $GITHUB_ENV fi + - name: set up tmate session for debugging - if: failure() && env.USE_TMATE + if: env.USE_TMATE uses: mxschmitt/action-tmate@v3 - timeout-minutes: 60