Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async versions of exportGraphics and exportPartGraphics #196

Open
dassaf4 opened this issue Mar 8, 2023 · 2 comments
Open

Add async versions of exportGraphics and exportPartGraphics #196

dassaf4 opened this issue Mar 8, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request geometry

Comments

@dassaf4
Copy link
Member

dassaf4 commented Mar 8, 2023

Requested to improve performance for Civil tools.

Copied from ADO #796962

@dassaf4 dassaf4 added this to the iTwin.js 4.0 milestone Mar 8, 2023
@dassaf4 dassaf4 self-assigned this Mar 8, 2023
@simnorm simnorm pinned this issue Mar 9, 2023
@calebmshafer calebmshafer unpinned this issue Mar 14, 2023
@dassaf4
Copy link
Member Author

dassaf4 commented Mar 16, 2023

IModelDb.exportGraphics calls into the backend's JSInterop::ExportGraphics, which already spawns a thread per element passed in. Matt was meticulous designing it for performance. Multithreading the other one may be prohibitively hard, but there could be other ways to improve its performance. @simnorm can you confirm you seek improved performance only for exportPartGraphics?

@dassaf4 dassaf4 removed this from the iTwin.js 4.0 milestone Mar 22, 2023
@bsy-nicholasw
Copy link

Hi @dassaf4, this request was to less about making the internals more performant and for the exportGraphics call to return a Promise so the backend doesn't block and wait for the result. Similar to generateElementGraphics https://www.itwinjs.org/reference/core-backend/imodels/imodeldb/generateelementgraphics/

@dassaf4 dassaf4 added the enhancement New feature or request label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request geometry
Projects
None yet
Development

No branches or pull requests

2 participants