Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-unicode trimming element insertion path for transformer case #190

Open
MichaelBelousov opened this issue Mar 7, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@MichaelBelousov
Copy link
Contributor

MichaelBelousov commented Mar 7, 2023

#180 made it impossible for the transformer to preserve code values in the iModels that already have non-unicode spaces (e.g.non-breaking space,  ) persisted in a code value. We have to add an API for use by the transformer to preserve the old behavior during element insert, to prevent people forking an iModel, getting some code values from master using raw ECSQL (without wrapping them in a Code instance which would fix that) and trying to find them in a branch which had its code values "fixed" by this change.

Technically we could also say "use the Code class" but that sounds like it will lead to confusing bugs during ECSQL usage on some models. We can close this issue if the consensus is "use Code"

@MichaelBelousov MichaelBelousov self-assigned this Mar 7, 2023
@MichaelBelousov MichaelBelousov added the bug Something isn't working label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant