Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flight Log previous hash match comparing current signature with previous signature #60

Open
abrbhat opened this issue Aug 8, 2019 · 0 comments
Open

Flight Log previous hash match comparing current signature with previous signature #60

abrbhat opened this issue Aug 8, 2019 · 0 comments

Comments

@abrbhat
Copy link
Member

abrbhat commented Aug 8, 2019

In submit flight log endpoint: https://github.com/iSpirt/digital-sky-api/blob/3ba72f51a883345f28d311c03a0dd2fb12eff0f5/src/main/java/com/ispirit/digitalsky/service/FlightLogServiceImpl.java#L41

It seems that previous flightLogEntry.signature is incorrectly being compared to current flightLogEntry.signature. Instead, previous flightLogEntry.signature should be compared to current flightLogEntry.flightLog.previousLogHash.

@sidd-shetty @sidhantgoel @suraj-shanbhag @CharanSahaj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abrbhat