Add linter rules

[nguyer]

Currently, this repo is set up to run golangci, but has no config file, so it's missing all of the rules that we apply to our other repos. We should add the .golangci.yml file from here: https://github.com/hyperledger/firefly/blob/main/.golangci.yml

Then we need to go through the code and address the issues that are uncovered.

[PanGan21]

Hi @nguyer, I would like to pick up this issue. Is just adding the .golangci.yml sufficient enough?

[nguyer]

Adding the .golangci.yml is the first step. Then make will start failing because the code doesn't meet the requirements of the linter rules in various places. So the second part of this issue is fixing those issues so that make succeeds again.

[PanGan21]

Hi @nguyer I think both subtasks are done. I would appreciate a first review for #108 :)

[nguyer]

Thanks! Sorry I missed the PR being opened for it. I'll take a look now!

[PanGan21]

I had quite some progress on this issue. Most of the errors are fixed. Some of them which include additional configuration are ignored for now. (e.g. adding timeouts on the server). Let me know what you think

[tobigiwa]

@nguyer is this issue still open? or how is progress on it @PanGan21 ?