Appease rust 1.79 clippies (#1651)

Signed-off-by: Sean Young <[email protected]>

Author: seanyoung

solang-parser/src/solidity.lalrpop

@@ -761,10 +761,7 @@ FunctionDefinition: Box<FunctionDefinition> = {
                     params,
                     attributes,
                     return_not_returns: None,
-                    returns: match returns {
-                        Some((returns, _)) => returns,
-                        None => Vec::new(),
-                    },
+                    returns: returns.map(|(v, _)| v).unwrap_or_default(),
                     body,
                 })
             },

src/bin/languageserver/mod.rs

@@ -2774,8 +2774,8 @@ impl LanguageServer for SolangServer {
                     character: 0,
                 },
                 end: Position {
-                    line: u32::max_value(),
-                    character: u32::max_value(),
+                    line: u32::MAX,
+                    character: u32::MAX,
                 },
             },
             new_text: source_formatted,

src/sema/expression/strings.rs

@@ -101,10 +101,10 @@ pub(super) fn get_digits(input: &mut std::str::CharIndices, len: usize) -> Resul
             }
             offset = match input.next() {
                 Some((i, _)) => i,
-                None => std::usize::MAX,
+                None => usize::MAX,
             };
         } else {
-            offset = std::usize::MAX;
+            offset = usize::MAX;
         }
 
         return Err(offset);

src/sema/yul/builtin.rs

@@ -4,6 +4,7 @@ use crate::Target;
 use phf::{phf_map, phf_set};
 use std::fmt;
 
+#[allow(unused)]
 pub struct YulBuiltinPrototype {
     pub name: &'static str,
     pub no_args: u8,

tests/solana.rs

@@ -793,7 +793,7 @@ fn sol_try_find_program_address(
 
     println!("program_id:{}", program_id.to_base58());
 
-    let bump_seed = [std::u8::MAX];
+    let bump_seed = [u8::MAX];
     let mut seeds_with_bump = seeds.to_vec();
     seeds_with_bump.push(&bump_seed);