[fix] When switching diagram type from none to any other one, check nullptr renderer when syncing to layer

gacarrillor · nyalldawson · commit a11f8aaa4fbd · 2024-11-06T12:37:48.000+11:00
diff --git a/src/gui/vector/qgsdiagramproperties.cpp b/src/gui/vector/qgsdiagramproperties.cpp
@@ -422,7 +422,7 @@ void QgsDiagramProperties::insertDefaults()
 void QgsDiagramProperties::syncToLayer()
 {
   const QgsDiagramRenderer *renderer = mLayer->diagramRenderer();
-  if ( renderer->rendererName() == QgsStackedDiagramRenderer::DIAGRAM_RENDERER_NAME_STACKED )
+  if ( renderer && renderer->rendererName() == QgsStackedDiagramRenderer::DIAGRAM_RENDERER_NAME_STACKED )
   {
     const QgsStackedDiagramRenderer *stackedRenderer = static_cast< const QgsStackedDiagramRenderer *>( renderer );
     if ( stackedRenderer->rendererCount() > 0 )

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ void QgsDiagramProperties::insertDefaults()`
`422`	`422`	`void QgsDiagramProperties::syncToLayer()`
`423`	`423`	`{`
`424`	`424`	`const QgsDiagramRenderer *renderer = mLayer->diagramRenderer();`
`425`		`- if ( renderer->rendererName() == QgsStackedDiagramRenderer::DIAGRAM_RENDERER_NAME_STACKED )`
	`425`	`+ if ( renderer && renderer->rendererName() == QgsStackedDiagramRenderer::DIAGRAM_RENDERER_NAME_STACKED )`
`426`	`426`	`{`
`427`	`427`	`const QgsStackedDiagramRenderer stackedRenderer = static_cast< const QgsStackedDiagramRenderer >( renderer );`
`428`	`428`	`if ( stackedRenderer->rendererCount() > 0 )`