Skip to content

Commit 79a34b1

Browse files
hugetimhugetim
committed
Convert %help requests to URL-safe
1 parent d4ca8ab commit 79a34b1

File tree

2 files changed

+138
-19
lines changed

2 files changed

+138
-19
lines changed

‎nbs/09_magics.ipynb

+136-18
Original file line numberDiff line numberDiff line change
@@ -1026,7 +1026,8 @@
10261026
"def _get_help_html(self, code):\n",
10271027
" html_base = \"https://www.stata.com\"\n",
10281028
" html_help = urllib.parse.urljoin(html_base, \"help.cgi?{}\")\n",
1029-
" reply = urllib.request.urlopen(html_help.format(code))\n",
1029+
" url_safe_code = urllib.parse.quote(code)\n",
1030+
" reply = urllib.request.urlopen(html_help.format(url_safe_code))\n",
10301031
" html = reply.read().decode(\"utf-8\")\n",
10311032
"\n",
10321033
" # Remove excessive extra lines (Note css: \"white-space: pre-wrap\")\n",
@@ -1129,28 +1130,145 @@
11291130
"metadata": {},
11301131
"outputs": [
11311132
{
1132-
"ename": "HTTPError",
1133-
"evalue": "HTTP Error 403: Forbidden",
1134-
"output_type": "error",
1135-
"traceback": [
1136-
"\u001b[1;31m---------------------------------------------------------------------------\u001b[0m",
1137-
"\u001b[1;31mHTTPError\u001b[0m Traceback (most recent call last)",
1138-
"Cell \u001b[1;32mIn[52], line 3\u001b[0m\n\u001b[0;32m 1\u001b[0m \u001b[38;5;66;03m#| eval: False\u001b[39;00m\n\u001b[0;32m 2\u001b[0m test_instance \u001b[38;5;241m=\u001b[39m StataMagics()\n\u001b[1;32m----> 3\u001b[0m out \u001b[38;5;241m=\u001b[39m \u001b[43mtest_instance\u001b[49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43m_get_help_html\u001b[49m\u001b[43m(\u001b[49m\u001b[38;5;124;43m\"\u001b[39;49m\u001b[38;5;124;43morder\u001b[39;49m\u001b[38;5;124;43m\"\u001b[39;49m\u001b[43m)\u001b[49m\n\u001b[0;32m 4\u001b[0m HTML(out)\n",
1139-
"Cell \u001b[1;32mIn[49], line 6\u001b[0m, in \u001b[0;36m_get_help_html\u001b[1;34m(self, code)\u001b[0m\n\u001b[0;32m 4\u001b[0m html_base \u001b[38;5;241m=\u001b[39m \u001b[38;5;124m\"\u001b[39m\u001b[38;5;124mhttps://www.stata.com\u001b[39m\u001b[38;5;124m\"\u001b[39m\n\u001b[0;32m 5\u001b[0m html_help \u001b[38;5;241m=\u001b[39m urllib\u001b[38;5;241m.\u001b[39mparse\u001b[38;5;241m.\u001b[39murljoin(html_base, \u001b[38;5;124m\"\u001b[39m\u001b[38;5;124mhelp.cgi?\u001b[39m\u001b[38;5;132;01m{}\u001b[39;00m\u001b[38;5;124m\"\u001b[39m)\n\u001b[1;32m----> 6\u001b[0m reply \u001b[38;5;241m=\u001b[39m \u001b[43murllib\u001b[49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43mrequest\u001b[49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43murlopen\u001b[49m\u001b[43m(\u001b[49m\u001b[43mhtml_help\u001b[49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43mformat\u001b[49m\u001b[43m(\u001b[49m\u001b[43mcode\u001b[49m\u001b[43m)\u001b[49m\u001b[43m)\u001b[49m\n\u001b[0;32m 7\u001b[0m html \u001b[38;5;241m=\u001b[39m reply\u001b[38;5;241m.\u001b[39mread()\u001b[38;5;241m.\u001b[39mdecode(\u001b[38;5;124m\"\u001b[39m\u001b[38;5;124mutf-8\u001b[39m\u001b[38;5;124m\"\u001b[39m)\n\u001b[0;32m 9\u001b[0m \u001b[38;5;66;03m# Remove excessive extra lines (Note css: \"white-space: pre-wrap\")\u001b[39;00m\n",
1140-
"File \u001b[1;32mc:\\Users\\tjhuegerich\\AppData\\Local\\anaconda3\\envs\\nbstata_dev\\Lib\\urllib\\request.py:216\u001b[0m, in \u001b[0;36murlopen\u001b[1;34m(url, data, timeout, cafile, capath, cadefault, context)\u001b[0m\n\u001b[0;32m 214\u001b[0m \u001b[38;5;28;01melse\u001b[39;00m:\n\u001b[0;32m 215\u001b[0m opener \u001b[38;5;241m=\u001b[39m _opener\n\u001b[1;32m--> 216\u001b[0m \u001b[38;5;28;01mreturn\u001b[39;00m \u001b[43mopener\u001b[49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43mopen\u001b[49m\u001b[43m(\u001b[49m\u001b[43murl\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mdata\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mtimeout\u001b[49m\u001b[43m)\u001b[49m\n",
1141-
"File \u001b[1;32mc:\\Users\\tjhuegerich\\AppData\\Local\\anaconda3\\envs\\nbstata_dev\\Lib\\urllib\\request.py:525\u001b[0m, in \u001b[0;36mOpenerDirector.open\u001b[1;34m(self, fullurl, data, timeout)\u001b[0m\n\u001b[0;32m 523\u001b[0m \u001b[38;5;28;01mfor\u001b[39;00m processor \u001b[38;5;129;01min\u001b[39;00m \u001b[38;5;28mself\u001b[39m\u001b[38;5;241m.\u001b[39mprocess_response\u001b[38;5;241m.\u001b[39mget(protocol, []):\n\u001b[0;32m 524\u001b[0m meth \u001b[38;5;241m=\u001b[39m \u001b[38;5;28mgetattr\u001b[39m(processor, meth_name)\n\u001b[1;32m--> 525\u001b[0m response \u001b[38;5;241m=\u001b[39m \u001b[43mmeth\u001b[49m\u001b[43m(\u001b[49m\u001b[43mreq\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mresponse\u001b[49m\u001b[43m)\u001b[49m\n\u001b[0;32m 527\u001b[0m \u001b[38;5;28;01mreturn\u001b[39;00m response\n",
1142-
"File \u001b[1;32mc:\\Users\\tjhuegerich\\AppData\\Local\\anaconda3\\envs\\nbstata_dev\\Lib\\urllib\\request.py:634\u001b[0m, in \u001b[0;36mHTTPErrorProcessor.http_response\u001b[1;34m(self, request, response)\u001b[0m\n\u001b[0;32m 631\u001b[0m \u001b[38;5;66;03m# According to RFC 2616, \"2xx\" code indicates that the client's\u001b[39;00m\n\u001b[0;32m 632\u001b[0m \u001b[38;5;66;03m# request was successfully received, understood, and accepted.\u001b[39;00m\n\u001b[0;32m 633\u001b[0m \u001b[38;5;28;01mif\u001b[39;00m \u001b[38;5;129;01mnot\u001b[39;00m (\u001b[38;5;241m200\u001b[39m \u001b[38;5;241m<\u001b[39m\u001b[38;5;241m=\u001b[39m code \u001b[38;5;241m<\u001b[39m \u001b[38;5;241m300\u001b[39m):\n\u001b[1;32m--> 634\u001b[0m response \u001b[38;5;241m=\u001b[39m \u001b[38;5;28;43mself\u001b[39;49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43mparent\u001b[49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43merror\u001b[49m\u001b[43m(\u001b[49m\n\u001b[0;32m 635\u001b[0m \u001b[43m \u001b[49m\u001b[38;5;124;43m'\u001b[39;49m\u001b[38;5;124;43mhttp\u001b[39;49m\u001b[38;5;124;43m'\u001b[39;49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mrequest\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mresponse\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mcode\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mmsg\u001b[49m\u001b[43m,\u001b[49m\u001b[43m \u001b[49m\u001b[43mhdrs\u001b[49m\u001b[43m)\u001b[49m\n\u001b[0;32m 637\u001b[0m \u001b[38;5;28;01mreturn\u001b[39;00m response\n",
1143-
"File \u001b[1;32mc:\\Users\\tjhuegerich\\AppData\\Local\\anaconda3\\envs\\nbstata_dev\\Lib\\urllib\\request.py:563\u001b[0m, in \u001b[0;36mOpenerDirector.error\u001b[1;34m(self, proto, *args)\u001b[0m\n\u001b[0;32m 561\u001b[0m \u001b[38;5;28;01mif\u001b[39;00m http_err:\n\u001b[0;32m 562\u001b[0m args \u001b[38;5;241m=\u001b[39m (\u001b[38;5;28mdict\u001b[39m, \u001b[38;5;124m'\u001b[39m\u001b[38;5;124mdefault\u001b[39m\u001b[38;5;124m'\u001b[39m, \u001b[38;5;124m'\u001b[39m\u001b[38;5;124mhttp_error_default\u001b[39m\u001b[38;5;124m'\u001b[39m) \u001b[38;5;241m+\u001b[39m orig_args\n\u001b[1;32m--> 563\u001b[0m \u001b[38;5;28;01mreturn\u001b[39;00m \u001b[38;5;28;43mself\u001b[39;49m\u001b[38;5;241;43m.\u001b[39;49m\u001b[43m_call_chain\u001b[49m\u001b[43m(\u001b[49m\u001b[38;5;241;43m*\u001b[39;49m\u001b[43margs\u001b[49m\u001b[43m)\u001b[49m\n",
1144-
"File \u001b[1;32mc:\\Users\\tjhuegerich\\AppData\\Local\\anaconda3\\envs\\nbstata_dev\\Lib\\urllib\\request.py:496\u001b[0m, in \u001b[0;36mOpenerDirector._call_chain\u001b[1;34m(self, chain, kind, meth_name, *args)\u001b[0m\n\u001b[0;32m 494\u001b[0m \u001b[38;5;28;01mfor\u001b[39;00m handler \u001b[38;5;129;01min\u001b[39;00m handlers:\n\u001b[0;32m 495\u001b[0m func \u001b[38;5;241m=\u001b[39m \u001b[38;5;28mgetattr\u001b[39m(handler, meth_name)\n\u001b[1;32m--> 496\u001b[0m result \u001b[38;5;241m=\u001b[39m \u001b[43mfunc\u001b[49m\u001b[43m(\u001b[49m\u001b[38;5;241;43m*\u001b[39;49m\u001b[43margs\u001b[49m\u001b[43m)\u001b[49m\n\u001b[0;32m 497\u001b[0m \u001b[38;5;28;01mif\u001b[39;00m result \u001b[38;5;129;01mis\u001b[39;00m \u001b[38;5;129;01mnot\u001b[39;00m \u001b[38;5;28;01mNone\u001b[39;00m:\n\u001b[0;32m 498\u001b[0m \u001b[38;5;28;01mreturn\u001b[39;00m result\n",
1145-
"File \u001b[1;32mc:\\Users\\tjhuegerich\\AppData\\Local\\anaconda3\\envs\\nbstata_dev\\Lib\\urllib\\request.py:643\u001b[0m, in \u001b[0;36mHTTPDefaultErrorHandler.http_error_default\u001b[1;34m(self, req, fp, code, msg, hdrs)\u001b[0m\n\u001b[0;32m 642\u001b[0m \u001b[38;5;28;01mdef\u001b[39;00m \u001b[38;5;21mhttp_error_default\u001b[39m(\u001b[38;5;28mself\u001b[39m, req, fp, code, msg, hdrs):\n\u001b[1;32m--> 643\u001b[0m \u001b[38;5;28;01mraise\u001b[39;00m HTTPError(req\u001b[38;5;241m.\u001b[39mfull_url, code, msg, hdrs, fp)\n",
1146-
"\u001b[1;31mHTTPError\u001b[0m: HTTP Error 403: Forbidden"
1147-
]
1133+
"data": {
1134+
"text/html": [
1135+
"\n",
1136+
"<html>\n",
1137+
"<head>\n",
1138+
"<meta content=\"noindex, nofollow\" name=\"robots\"/>\n",
1139+
"<title>StataNow 18 help for graph set</title>\n",
1140+
"<link href=\"/includes/css/stylehelp.css\" rel=\"stylesheet\" type=\"text/css\"/>\n",
1141+
"<style type=\"text/css\">h2 {\n",
1142+
" font-family: Arial,Helvetica,Helv,sans-serif;\n",
1143+
" color: #000000;\n",
1144+
"}\n",
1145+
"\n",
1146+
"pre {\n",
1147+
" margin: 10px;\n",
1148+
"}\n",
1149+
"\n",
1150+
"table {\n",
1151+
" background-color: transparent;\n",
1152+
" border-color: transparent;\n",
1153+
" bgcolor: transparent;\n",
1154+
"}\n",
1155+
"\n",
1156+
"tr {\n",
1157+
" background-color: transparent;\n",
1158+
" border-color: transparent;\n",
1159+
" bgcolor: transparent;\n",
1160+
"}\n",
1161+
"\n",
1162+
"body {\n",
1163+
" background-color: transparent;\n",
1164+
" border-color: transparent;\n",
1165+
" margin: 0px;\n",
1166+
"}\n",
1167+
"\n",
1168+
"div {\n",
1169+
" background-color: transparent;\n",
1170+
" border-color: transparent;\n",
1171+
"}\n",
1172+
"</style>\n",
1173+
"</head>\n",
1174+
"<body>\n",
1175+
"\n",
1176+
"<p><table align=\"center\" bgcolor=\"transparent\" border=\"1\" cellpadding=\"5\" cellspacing=\"0\">\n",
1177+
"<tr bgcolor=\"transparent\"><td align=\"left\" bgcolor=\"transparent\" valign=\"top\">\n",
1178+
"<!-- END HEAD -->\n",
1179+
"\n",
1180+
"<pre>\n",
1181+
"<p><b>[G-2] graph set</b> -- Set graphics options\n",
1182+
"<p><p><a name=\"syntax\"></a><b><u>Syntax</u></b>\n",
1183+
"<p> Manage graph print settings\n",
1184+
"<p> <b><u>gr</u></b><b>aph</b> <b>set</b> <b>print</b> [<i>setopt</i> <i>setval</i>]\n",
1185+
"<p><p> Manage graph export settings\n",
1186+
"<p> <b><u>gr</u></b><b>aph</b> <b>set</b> [<i>exporttype</i>] [<i>setopt</i> <i>setval</i>]\n",
1187+
"<p> where <i>exporttype</i> is the export file type and may be one of \n",
1188+
"<p> <b>ps</b> | <b>eps</b> | <b>svg</b> | <b>pdf</b>\n",
1189+
"<p> and <i>setopt</i> is the option to set with the setting <i>setval</i>.\n",
1190+
"<p><p> Manage Graph window font settings\n",
1191+
"<p> <b><u>gr</u></b><b>aph</b> <b>set</b> <b>window</b> <b>fontface</b> { <i>fontname</i> | <b>default</b> }\n",
1192+
" <b><u>gr</u></b><b>aph</b> <b>set</b> <b>window</b> <b>fontfacemono</b> { <i>fontname</i> | <b>default</b> }\n",
1193+
" <b><u>gr</u></b><b>aph</b> <b>set</b> <b>window</b> <b>fontfacesans</b> { <i>fontname</i> | <b>default</b> }\n",
1194+
" <b><u>gr</u></b><b>aph</b> <b>set</b> <b>window</b> <b>fontfaceserif</b> { <i>fontname</i> | <b>default</b> }\n",
1195+
" <b><u>gr</u></b><b>aph</b> <b>set</b> <b>window</b> <b>fontfacesymbol</b> { <i>fontname</i> | <b>default</b> }\n",
1196+
"<p><p><a name=\"description\"></a><b><u>Description</u></b>\n",
1197+
"<p> <b>graph</b> <b>set</b> without options lists the current graphics font, print, and\n",
1198+
" export settings for all <i>exporttype</i>s. <b>graph set</b> with <b>window</b>, <b>print</b>, or\n",
1199+
" <i>exporttype</i> lists the current settings for the Graph window, for printing,\n",
1200+
" or for the specified <i>exporttype</i>, respectively.\n",
1201+
"<p> <b>graph</b> <b>set</b> <b>print</b> allows you to change the print settings for graphics.\n",
1202+
"<p> <b>graph</b> <b>set</b> <i>exporttype</i> allows you to change the graphics export settings\n",
1203+
" for export file type <i>exporttype</i>.\n",
1204+
"<p> <b>graph</b> <b>set</b> <b>window</b> <b>fontface</b><i>*</i> allows you to change the Graph window font\n",
1205+
" settings. (To change font settings for graphs exported to PostScript,\n",
1206+
" Encapsulated PostScript, Scalable Vector Graphic, or Portable Document\n",
1207+
" Format files, use <b>graph</b> <b>set</b> {<b>ps</b>|<b>eps</b>|<b>svg</b>|<b>pdf</b>} <b>fontface</b><i>*</i>; see <a href=\"https://www.stata.com/help.cgi?ps_options\" target=\"_blank\"><b>[G-3]</b></a>\n",
1208+
" <a href=\"https://www.stata.com/help.cgi?ps_options\" target=\"_blank\"><i>ps_options</i></a>, <a href=\"https://www.stata.com/help.cgi?eps_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?eps_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?eps_options\" target=\"_blank\"><i>eps_options</i></a>, <a href=\"https://www.stata.com/help.cgi?svg_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?svg_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?svg_options\" target=\"_blank\"><i>svg_options</i></a>, or <a href=\"https://www.stata.com/help.cgi?pdf_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?pdf_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?pdf_options\" target=\"_blank\"><i>pdf_options</i></a>.)\n",
1209+
" If <i>fontname</i> contains spaces, enclose it in double quotes. If you specify\n",
1210+
" <b>default</b> for any of the <b>fontface</b><i>*</i> settings, the default setting will be\n",
1211+
" restored.\n",
1212+
"<p><p><a name=\"remarks\"></a><b><u>Remarks</u></b>\n",
1213+
"<p> Remarks are presented under the following headings:\n",
1214+
"<p> <a href=\"https://www.stata.com/help.cgi?graph_set%23remarks1\" target=\"_blank\">Overview</a>\n",
1215+
" <a href=\"https://www.stata.com/help.cgi?graph_set%23remarks2\" target=\"_blank\">Setting defaults</a>\n",
1216+
"<p><p><a name=\"remarks1\"></a><b><u>Overview</u></b>\n",
1217+
"<p> <b>graph set</b> allows you to permanently set the primary font face used in the\n",
1218+
" Graph window as well as the font faces to be used for the four Stata\n",
1219+
" \"font faces\" supported by the graph SMCL tags <b>{stMono}</b>, <b>{stSans}</b>,\n",
1220+
" <b>{stSerif}</b>, and <b>{stSymbol}</b>. See <a href=\"https://www.stata.com/help.cgi?graph_text\" target=\"_blank\"><b>[G-4]</b></a><a href=\"https://www.stata.com/help.cgi?graph_text\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?graph_text\" target=\"_blank\"><i>text</i></a> for more details on these SMCL\n",
1221+
" tags.\n",
1222+
"<p> <b>graph set</b> also allows you to permanently set any of the options supported\n",
1223+
" by <b>graph print</b> (see <a href=\"https://www.stata.com/help.cgi?graph_print\" target=\"_blank\"><b>[G-2] graph print</b></a>) or by the specific export file\n",
1224+
" types provided by <b>graph export</b> (see <a href=\"https://www.stata.com/help.cgi?graph_export\" target=\"_blank\"><b>[G-2] graph export</b></a>).\n",
1225+
"<p> To find out more about the <b>graph</b> <b>set</b> <b>print</b> <i>setopt</i> options and their\n",
1226+
" associated values (<i>setval</i>), see <a href=\"https://www.stata.com/help.cgi?pr_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?pr_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?pr_options\" target=\"_blank\"><i>pr_options</i></a>.\n",
1227+
"<p> Some graphics file types supported by <a href=\"https://www.stata.com/help.cgi?graph%2Bexport\" target=\"_blank\"><b>graph export</b></a> have options that can\n",
1228+
" be set. The file types that allow option settings and their associated\n",
1229+
" <i>exporttype</i>s are\n",
1230+
"<p> <i>exporttype</i> Description Available settings\n",
1231+
" ------------------------------------------------------------\n",
1232+
" <b>ps</b> PostScript <a href=\"https://www.stata.com/help.cgi?ps_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?ps_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?ps_options\" target=\"_blank\"><i>ps_options</i></a>\n",
1233+
" <b>eps</b> Encapsulated PostScript <a href=\"https://www.stata.com/help.cgi?eps_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?eps_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?eps_options\" target=\"_blank\"><i>eps_options</i></a>\n",
1234+
" <b>svg</b> Scalable Vector Graphics <a href=\"https://www.stata.com/help.cgi?svg_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?svg_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?svg_options\" target=\"_blank\"><i>svg_options</i></a>\n",
1235+
" <b>pdf</b> Portable Document Format <a href=\"https://www.stata.com/help.cgi?pdf_options\" target=\"_blank\"><b>[G-3]</b></a><a href=\"https://www.stata.com/help.cgi?pdf_options\" target=\"_blank\"> </a><a href=\"https://www.stata.com/help.cgi?pdf_options\" target=\"_blank\"><i>pdf_options</i></a>\n",
1236+
" ------------------------------------------------------------\n",
1237+
"<p><p><a name=\"remarks2\"></a><b><u>Setting defaults</u></b>\n",
1238+
"<p> If you always want the Graph window to use Times New Roman as its default\n",
1239+
" font, you could type\n",
1240+
"<p> <b>. graph set window fontface \"Times New Roman\"</b>\n",
1241+
"<p> Later, you could type\n",
1242+
"<p> <b>. graph set window fontface default</b>\n",
1243+
"<p> to restore the factory setting.\n",
1244+
"<p> To change the font used by <b>{stMono}</b> in the Graph window, you could type\n",
1245+
"<p> <b>. graph set window fontfacemono \"Lucida Console\"</b>\n",
1246+
"<p> and to reset it, you could type\n",
1247+
"<p> <b>. graph set window fontfacemono default</b>\n",
1248+
"<p> You can list the current graph settings by typing\n",
1249+
"<p> <b>. graph set</b>\n",
1250+
"</p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></p></pre>\n",
1251+
"<!-- BEGIN FOOT -->\n",
1252+
"</td></tr></table>\n",
1253+
"\n",
1254+
"\n",
1255+
"\n",
1256+
"</p></body>\n",
1257+
"</html>\n"
1258+
],
1259+
"text/plain": [
1260+
"<IPython.core.display.HTML object>"
1261+
]
1262+
},
1263+
"execution_count": null,
1264+
"metadata": {},
1265+
"output_type": "execute_result"
11481266
}
11491267
],
11501268
"source": [
11511269
"#| eval: False\n",
11521270
"test_instance = StataMagics()\n",
1153-
"out = test_instance._get_help_html(\"order\")\n",
1271+
"out = test_instance._get_help_html(\"graph set\")\n",
11541272
"HTML(out)"
11551273
]
11561274
},

‎nbstata/magics.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,8 @@ def _magic_frheadtail(self, code, kernel, cell, tail):
361361
def _get_help_html(self, code):
362362
html_base = "https://www.stata.com"
363363
html_help = urllib.parse.urljoin(html_base, "help.cgi?{}")
364-
reply = urllib.request.urlopen(html_help.format(code))
364+
url_safe_code = urllib.parse.quote(code)
365+
reply = urllib.request.urlopen(html_help.format(url_safe_code))
365366
html = reply.read().decode("utf-8")
366367

367368
# Remove excessive extra lines (Note css: "white-space: pre-wrap")

0 commit comments

Comments
 (0)