clang-tidy warning as error

huangminghuang · huangminghuang · commit 7abfcf6ee893 · 2025-03-07T13:44:31.000-06:00
diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -37,7 +37,7 @@
               compiler: clang-18
               protoc: find
               sanitize: OFF
-              extra_cmake_configure_flags: -DCMAKE_CXX_CLANG_TIDY=clang-tidy-18
+              extra_cmake_configure_flags: "-DCMAKE_CXX_CLANG_TIDY=clang-tidy-18;-warnings-as-errors=*"
 
       runs-on: ubuntu-24.04
   
diff --git a/include/hpp_proto/hpp_options.proto b/include/hpp_proto/hpp_options.proto
@@ -1,3 +1,4 @@
+syntax = "proto2";
 import "google/protobuf/descriptor.proto";
 package hpp.proto;
 
diff --git a/third-parties.cmake b/third-parties.cmake
@@ -27,6 +27,7 @@ get_target_property(IS_UTF8_COMPILER_OPTIONS is_utf8 COMPILE_OPTIONS)
 if(IS_UTF8_COMPILER_OPTIONS MATCHES "fsanitize=address")
     message(FATAL_ERROR "is_utf8 is not compatible with address sanitizer")
 endif()
+set_target_properties(is_utf8 PROPERTIES CXX_CLANG_TIDY "")
 
 CPMAddPackage("gh:fmtlib/fmt#10.1.0")
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+syntax = "proto2";`
`1`	`2`	`import "google/protobuf/descriptor.proto";`
`2`	`3`	`package hpp.proto;`
`3`	`4`