a couple of issues

[ctf0]

• the "htmlhint.documentSelector wont work because of

  vscode-htmlhint/htmlhint/package.json

  Line 32 in 07db8b2

  "onLanguage:html"

• htmlhint.configFile isnt available

  vscode-htmlhint/htmlhint/package.json

  Line 39 in 07db8b2

  "properties": {

REF:
https://github.com/htmlhint/vscode-htmlhint/tree/main/htmlhint#settings

[coliff]

Thanks for reporting these issues!

• On that first issue, is the solution to change the activationEvents to onFileSystem:file like you did on your fork? Does that work as expected with no problems?
• For the second do you have a suggested fix for htmlhint.configFile?

[ctf0]

both of the issues are solved on my branch yes, as for does it work https://marketplace.visualstudio.com/items?itemName=ctf0.htmlhint the installation count says it all especially that this is all what i've added

[michael-nok]

@coliff Could you please include just the activationEvents changes provided by @ctf0 to allow for more startup options?

[rubensa]

Any work on this? I'm trying to validate some html inside markdown documents.

I think that the:

    "activationEvents": [
        "onFileSystem:file"
    ],

is needed so the extension can be activated for other files than HTML (so it can be used for markdown files if I specify markdown inside htmlhint.documentSelector configuration) .

The other change I can see is the addition of:

                "htmlhint.documentSelector": {
                    "items": {
                        "type": "string"
                    }
                }

that I don't know if it is really necessary.

[rubensa]

@coliff For the htmlhint.configFile part @ctf0 added the htmlhint.optionsFile configuration.

In htmlhint-server/src/server.ts he added optionsFile to the Settings interface:

interface Settings {
    htmlhint: {
        enable: boolean;
        options: any;
        optionsFile: string;
    },
    [key: string]: any;
}

and the code to load the configuration if the option is specified inside getConfiguration:

    else if (settings.htmlhint && settings.htmlhint.optionsFile) {
        options = loadConfigurationFile(settings.htmlhint.optionsFile)
    }

[coliff]

sorry for the delay on this... I'd been testing that change locally and hope to get an update with this change out soon. thanks!

[rubensa]

@coliff Sorry to bother you but it's been more than a year since you said you where testing the change locally. Any news on this?

[inosik]

Is there no other way to achieve what you intend other than onFileSystem:file? I'm trying to set up VS Code as my editor for Git and HTMLHint has an activation time of over 500 ms.

[coliff]

Is there no other way to achieve what you intend other than onFileSystem:file? I'm trying to set up VS Code as my editor for Git and HTMLHint has an activation time of over 500 ms.

I don't think that change impacts activation time much. The latest version of the extension (1.0.5) has an activation time of 120ms on my Windows 11 laptop, and the first version (1.0.0) has an extension time of 110ms so it's nearly identical.

[inosik]

Just to be sure, are you talking about this value?

This seems to be the sum of the time needed to load the extension and the time to actually activate it. The loading time is typically much higher for HTMLHint. Here's a snippet of the output of the "Developer: Startup Performance" command:

Extension	Eager	Load Code	Call Activate	Finish Activate	Event	By
HTMLHint.vscode-htmlhint	false	671	30	0	onFileSystem:file	HTMLHint.vscode-htmlhint

But I think I'll investigate this further when I have the time and come back to you if I have something actionable.

[coliff]

yes, but I have a very fast, relatively new Laptop which perhaps skews things somewhat 😅