Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client creates API request on login even though input is invalid #61

Open
bemoty opened this issue Mar 20, 2021 · 0 comments
Open

Client creates API request on login even though input is invalid #61

bemoty opened this issue Mar 20, 2021 · 0 comments
Labels
bug This issue is about a malfunction frontend This issue is related to the front end Flutter application low-priority This issue has low priority

Comments

@bemoty
Copy link
Member

bemoty commented Mar 20, 2021

Found while testing #60

The client performs some very basic sanity checks in the sign in / sign up screen but performs an API request even if the sanity check fails. (Client shows a dialog when the sanity check fails but also shows a toast when the API request fails)

Should return in this if so that the API request below is not executed

sokka/client/lib/screens/auth/LoginScreen.dart

Line 142 in e2b7fb3

if (this._email.isEmpty || this._password.isEmpty) {

@bemoty bemoty added bug This issue is about a malfunction low-priority This issue has low priority frontend This issue is related to the front end Flutter application labels Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is about a malfunction frontend This issue is related to the front end Flutter application low-priority This issue has low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bemoty