Remove legacy GetData

Author: wwahammy

.rubocop.yml

@@ -306,7 +306,6 @@ AllCops:
     - 'app/jobs/webhook_transmit_job.rb'
     - 'app/jobs/stripe_account_create_job.rb'
     - 'app/legacy_lib/import_civicrm_payments.rb'
-    - 'app/legacy_lib/get_data.rb'
     - 'app/legacy_lib/name_copy_naming_algorithm.rb'
     - 'app/legacy_lib/health_report.rb'
     - 'app/legacy_lib/qexpr_query_chunker.rb'

app/legacy_lib/create_stripe_account.rb

@@ -6,7 +6,7 @@
 
 module CreateStripeAccount
   def self.for_nonprofit(user, params)
-    fst_name, lst_name = Format::Name.split_full(GetData.chain(user, :profile, :name))
+    fst_name, lst_name = Format::Name.split_full(user&.profile&.name))
     Stripe::Account.create(
       managed: true,
       email: params[:email],

app/legacy_lib/get_data.rb

@@ -115,9 +115,9 @@ def self.with_stripe(data)
     charge.amount = data[:amount]
     charge.fee = fee
 
-    charge.stripe_charge_id = GetData.chain(stripe_charge, :id)
+    charge.stripe_charge_id = stripe_charge&.id
     charge.failure_message = failure_message
-    charge.status = GetData.chain(stripe_charge, :paid) ? 'pending' : 'failed'
+    charge.status = stripe_charge&.paid ? 'pending' : 'failed'
     charge.card = card
     charge.donation = Donation.where('id = ?', data[:donation_id]).first
     charge.supporter = supporter

app/legacy_lib/insert_charge.rb

@@ -115,7 +115,7 @@ def execute(user)
 				if table_data['donation'] && table_data['donation']['id']
 					table_data['offsite_payment'] = Qx.insert_into(:offsite_payments).values(
 						gross_amount: table_data['donation']['amount'],
-						check_number: GetData.chain(table_data['offsite_payment'], 'check_number'),
+						check_number: table_data['offsite_payment'] && table_data['offsite_payment']['check_number'],
 						kind: table_data['offsite_payment'] && table_data['offsite_payment']['check_number'] ? 'check' : '',
 						nonprofit_id: nonprofit.id,
 						supporter_id: table_data['supporter']['id'],

app/models/import_request.rb

@@ -55,5 +55,5 @@
 			placeholder='Postal Code'>
 	</fieldset>
 
-	<input type='hidden' name='profile_id' value='<%= GetData.chain(current_user, :profile, :id) %>'>
+	<input type='hidden' name='profile_id' value='<%= current_user&.profile&.id%>'>
 </div>

app/views/cards/_fields.html.erb

@@ -31,7 +31,7 @@
 		</tr>
 
     <tr>
-    <% if GetData.chain(charge.card, :name).present? %>
+    <% if charge.card&.name.present? %>
       <td><strong>Card</strong></td>
       <td> <%= charge.card.name %> </td>
     <% end %>

app/views/charge_mailer/_payment_receipt.html.erb

@@ -88,7 +88,7 @@
     <% if charge %>
 		<tr>
   			<td><strong><%= t('donation.payment_id') %></strong></td>
-			<td> <%= GetData.chain(donation.payment, :id) %></td>
+			<td> <%= donation.payment&.id %></td>
 		</tr>
     <% end %>
 

app/views/donation_mailer/_donation_payment_table.html.erb

@@ -60,7 +60,7 @@ json.data do
         json.extract! event, :name, :id
         json.url event_locateable_url(event)
       end
-      json.levels @payment.tickets.map { |t| "#{GetData.chain(t.ticket_level, :name)} (#{t.quantity}x)" }.join(', ')
+      json.levels @payment.tickets.map { |t| "#{t.ticket_level&.name} (#{t.quantity}x)" }.join(', ')
       json.discount @payment.tickets.map { |t| t.event_discount ? "#{t.event_discount.name} (#{t.event_discount.percent}%)" : nil }.compact.join(', ')
   end if @payment&.tickets&.last&.event
 

app/views/nonprofits/payments/show.jbuilder

@@ -24,7 +24,7 @@
 						<%= link_to(donation.nonprofit.name, donation.nonprofit.url) %>
 					</td>
 					<td> <%= format_date_to_mdY(donation.created_at) %></td>
-					<td> <%= GetData.chain(donation.card, :name) %> </td>
+					<td> <%= donation.card&.name %> </td>
 				</tr>
 			<% end %>
 		</tbody>

app/views/profiles/_donations.html.erb

@@ -14,7 +14,7 @@
           <strong>Ticket Level</strong>
         </td>
         <td>
-          <%= GetData.chain(ticket, :ticket_level, :name) != nil ?  GetData.chain(ticket, :ticket_level, :name) : 'n/a' %>
+          <%= ticket&.ticket_level&.name.present? ?  ticket&.ticket_level&.name : 'n/a' %>
         </td>
       </tr>
 			<tr>
@@ -23,19 +23,19 @@
 			</tr>
 			<tr>
 				<td><strong>Name</strong></td>
-				<td> <%= GetData.chain(ticket, :supporter, :name) %></td>
+				<td> <%= ticket&.supporter&.name %></td>
 			</tr>
 			<tr>
 				<td><strong>Email</strong></td>
-				<td><%= GetData.chain(ticket, :supporter, :email) %></td>
+				<td><%= ticket&.supporter&.email %></td>
 			</tr>
 			<tr>
 				<td><strong>Ticket ID</strong></td>
 				<td> <%= ticket.id %></td>
 			</tr>
 			<tr>
 				<td><strong>Comment</strong></td>
-				<td> <%= GetData.chain(ticket, :donation, :comment) || 'None' %></td>
+				<td> <%= ticket&.donation&.comment || 'None' %></td>
 			</tr>
       <% if tickets.length != 1 %>
         <tr colspan='2'><td><p></p></td></tr>

app/views/ticket_mailer/_tickets.html.erb

@@ -67,7 +67,7 @@
   <p>
     Your payment of $<strong><%= Format::Currency.cents_to_dollars(@charge.amount) %></strong>
     for the event <strong><a href='<%= Format::Url.concat(root_url, @event.url) %>'><%= @event.name %></a></strong>
-    using <strong><%= GetData.chain(@charge, :card, :name) || 'Unknown card' %></strong>
+    using <strong><%= @charge&.card&.name || 'Unknown card' %></strong>
     was successful.
   </p><br>