Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iwlwifi-gl firmware needed for Intel BE200 Wi-Fi 7 card #3668

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add iwlwifi-gl firmware needed for Intel BE200 Wi-Fi 7 card #3668

merged 1 commit into from
Nov 14, 2024
+4 −1

Conversation

antst
Copy link
Contributor

@antst antst commented Nov 12, 2024 •
edited by coderabbitai bot
Loading

Adds iwlwifi-gl firwmare, which is required for Intel BE200 card. Targets are generic_aarch64, generic_x86_64 and ova.
Closes #3643.
Depends on merge of home-assistant/buildroot#59

Summary by CodeRabbit

  • New Features

    • Added support for Intel Wireless WiFi 6E firmware across multiple configurations, enhancing wireless connectivity options.

  • Configuration Updates

    • Updated subproject commit reference to a newer state for improved stability and features.

home-assistant[bot]
home-assistant bot previously requested changes Nov 12, 2024
View reviewed changes
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antst

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 12, 2024 19:47
@antst antst mentioned this pull request Nov 12, 2024
Closed
@sairon sairon changed the title Enable adds iwlwifi-gl firwmare, which is required for Intel BE200 ca… Add iwlwifi-gl firmware needed for Intel BE200 Wi-Fi 7 card Nov 13, 2024
@sairon sairon added board/ova Open Virtual Appliance (Virtual Machine) board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) board/generic-aarch64 Generic aarch64 machine wifi Wi-Fi related issues labels Nov 13, 2024
sairon
sairon reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just please update the submodule hash once the Buildroot PR is updated and mark the PR as ready for review. Thanks!

@antst
Copy link
Contributor Author

antst commented Nov 13, 2024 •
edited
Loading

I am going to update hash when Buildroot PR is merged, so then it will be ready to merge "as it" here.

@antst @sairon
Add iwlwifi-gl firmware needed for Intel BE200 Wi-Fi 7 card
17d7199 
Add iwlwifi-gl firmware, which is required for Intel BE200 card. Targets are
generic_aarch64, generic_x86_64 and ova.

* buildroot 19027bc796...1d7407c66b (1):
  > package/linux-firmware: add iwlwifi gl firmware

Closes #3643.
sairon
sairon approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the PR with the new hash. Thanks again for you contribution!

@sairon sairon marked this pull request as ready for review November 14, 2024 08:22
@sairon sairon merged commit b28dd8c into home-assistant:dev Nov 14, 2024
2 of 3 checks passed
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request include an update to the subproject commit reference and the addition of a new configuration option for Linux firmware across multiple configuration files. The subproject's commit reference was changed to a newer version, and the configuration files for AArch64, x86_64, and ova architectures now include support for the Intel Wireless WiFi 6E firmware.

Changes

File Path Change Summary
buildroot-external/configs/generic_aarch64_defconfig New configuration option added: BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_GL=y
buildroot-external/configs/generic_x86_64_defconfig New configuration option added: BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_GL=y
buildroot-external/configs/ova_defconfig New configuration option added: BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_GL=y
buildroot Subproject commit updated: 19027bc79657... → 1d7407c66b22...

Assessment against linked issues

Objective Addressed Explanation
Update firmware for Intel BE200 WLAN adapter (#3643) ✅
Ensure compatibility with newer firmware versions (#3643) ✅
Improve early loading of firmware (#3643) ❌ No changes related to early mounting of firmware.
Inject firmware into initrd (#3643) ❓ Unclear if the changes address this requirement.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairon sairon sairon approved these changes

@home-assistant home-assistant[bot] home-assistant[bot] left review comments

Assignees
No one assigned
Labels
board/generic-aarch64 Generic aarch64 machine board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) board/ova Open Virtual Appliance (Virtual Machine) cla-signed wifi Wi-Fi related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to load firmware for wlan adapter
2 participants
@antst @sairon