Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow Jawk to print to an arbitrary OutputStream #11

Open
bertysentry opened this issue Jan 27, 2018 · 9 comments
Open

Enhancement: Allow Jawk to print to an arbitrary OutputStream #11

bertysentry opened this issue Jan 27, 2018 · 9 comments

Comments

@bertysentry
Copy link
Collaborator

When not printing to a file, AVM.interpret() will print to System.out. One may need to print to something else (Socket, ByteArrayOutputStream, etc.).

Add an option in the AwkSettings class to set the output stream.

The same probably needs to be done for compilation.

@cdrasmussen
Copy link

cdrasmussen commented Jan 27, 2018 via email

@eyalroth
Copy link
Collaborator

I think this repository is pretty much dead now. I tried to revive it with PR #10 but I didn't get any response from the owner @hoijui.

I actually have plenty more fixes and features working for me locally -- including the one you just asked for -- but seeing how the repository is dead I gave up on contributing them.

@cdrasmussen
Copy link

cdrasmussen commented Jan 27, 2018 via email

@bertysentry
Copy link
Collaborator Author

@eyalroth I see you forked the Jawk repo, but it looks like you only pushed your changes to fix the bug "Compiled Awk can't read input".
Would you mind sharing your bug fixes and enhancements? (just pushing to your repo).
If needed, I'd be happy to contribute if I see fit.
This way, you'd become the new official maintainer of Jawk ;-)

@eyalroth
Copy link
Collaborator

I guess I have my work cut out for me, don't I? :)

@cdrasmussen
Copy link

cdrasmussen commented Jan 28, 2018 via email

@eyalroth
Copy link
Collaborator

Unfortunately no, most of it is in use on my private repository which I cannot simply publish, but I'll make the effort to transfer it to the public one.

@cdrasmussen
Copy link

cdrasmussen commented Jan 31, 2018 via email

@hoijui
Copy link
Owner

hoijui commented Jan 31, 2018

i have added you as a collaborator ( @eyalroth ).
sorry for the non-existent feedback in general.
the usual excuse: too much other stuff to do
plus, i also do not use JAWK myself anymore since years, and never dived into any of the core code, so reviewing pull requests thoroughly would have taken me a long time.
tell me if you need something else; i do get messages per email, and i still read them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants