cmd/feedback: remove flag shorthands that are conflicting with global flags

Tony Worm · Tony Worm · commit 1d6af4774554 · 2024-12-12T18:54:02.000-05:00
diff --git a/.hof/shadow/cli/cmd/hof/flags/feedback.go b/.hof/shadow/cli/cmd/hof/flags/feedback.go
@@ -16,8 +16,8 @@ type FeedbackPflagpole struct {
 func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) {
 	// pflags
 
-	fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)")
-	fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated")
+	fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)")
+	fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated")
 }
 
 var FeedbackPflags FeedbackPflagpole
diff --git a/cmd/hof/flags/feedback.go b/cmd/hof/flags/feedback.go
@@ -16,8 +16,8 @@ type FeedbackPflagpole struct {
 func SetupFeedbackPflags(fset *pflag.FlagSet, fpole *FeedbackPflagpole) {
 	// pflags
 
-	fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)")
-	fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated")
+	fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)")
+	fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated")
 }
 
 var FeedbackPflags FeedbackPflagpole
diff --git a/design/cmds/feedback.cue b/design/cmds/feedback.cue
@@ -17,14 +17,14 @@ FeedbackCommand: schema.Command & {
 	Pflags: [{
 		Name:    "issue"
 		Long:    "issue"
-		Short:   "I"
+		Short:   ""
 		Type:    "bool"
 		Default: "false"
 		Help:    "create an issue (discussion is default)"
 	}, {
 		Name:    "labels"
 		Long:    "labels"
-		Short:   "L"
+		Short:   ""
 		Type:    "string"
 		Default: "\"feedback\""
 		Help:    "labels,comma,separated"

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,8 @@ type FeedbackPflagpole struct {`
`16`	`16`	`func SetupFeedbackPflags(fset pflag.FlagSet, fpole FeedbackPflagpole) {`
`17`	`17`	`// pflags`
`18`	`18`
`19`		`- fset.BoolVarP(&(fpole.Issue), "issue", "I", false, "create an issue (discussion is default)")`
`20`		`- fset.StringVarP(&(fpole.Labels), "labels", "L", "feedback", "labels,comma,separated")`
	`19`	`+ fset.BoolVarP(&(fpole.Issue), "issue", "", false, "create an issue (discussion is default)")`
	`20`	`+ fset.StringVarP(&(fpole.Labels), "labels", "", "feedback", "labels,comma,separated")`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`var FeedbackPflags FeedbackPflagpole`