Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Better error messages / handling for send validation. #57

Closed
haustraliaer opened this issue Jun 3, 2014 · 5 comments
Closed

Better error messages / handling for send validation. #57

haustraliaer opened this issue Jun 3, 2014 · 5 comments
Labels

Comments

@haustraliaer
Copy link
Contributor

Currently I've just implemented a simple function (here: 7fbac19) for stopping the user from sending unless they have entered something into the address bar and also checking if they have enough funds.

If the checks are met, then clicking confirm takes them to the send confirmation step.

Ideally the confirm button shouldn't seem like it is able to be clicked until the checks are met, so perhaps we should test on keyup etc as well. Also there should be some visual validation as to what they have got incorrect if they try and click confirm but it fails.

@haustraliaer
Copy link
Contributor Author

I've now set it up with contextual error popups - but this probably still needs some inline highlighting of the specific fields in question. And I think the error module should probably get some more love in regards to icons as it's currently using a temporary png.

errors

@weilu
Copy link
Member

weilu commented Jun 4, 2014

@haustraliaer nice! Is this using the error-modal module?

@haustraliaer
Copy link
Contributor Author

Yep using the error component, though we might be able to tidy up the validation functions a bit - I'll leave that for the code review.

@weilu weilu added the UX label Jun 11, 2014
@weilu
Copy link
Member

weilu commented Jun 26, 2014

@haustraliaer I've reworked the send validation. Are there more to do for this ticket?

@haustraliaer
Copy link
Contributor Author

All done here but a new issue has come up -> #132

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants