-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow list being a requirement is not clear in the UI #9746
Comments
Optionally, the allowlist should not be considered a requirement. The reason being that it is impossible to create the following gating rule: meet all of the token threshold requirements OR be in the allowlist. The downside with excluding the allowlist from the requirements is that you cannot apply token threshold requirements to allow listed users i.e. you can't do: meet any number of token threshold requirements AND be in the allowlist. It seems to me that the allowlist is better utilized as a whitelist like in the OR case where token threshold requirements never apply to whitelisted members but growth/product would know best here. |
agree with @timolegros here that the Allowlist should not be considered a requirement, probably need to be communicated better in the UI. @sssssabinaaa likely need your input here |
If the allowlist should not be considered part of the requirements then I don't think we need any UI changes. In fact the copy above the allow list settings already indicates that it is not part of the requirements (we could maybe update "conditions' to "requirements" to make it more clear). |
to reduce confusion the "necessary requirements" section should be above the section with the ERC token selection |
Aight so @Israellund this is a 2fer:
|
Description
#9690 (comment)
We need to clarify that the allowlist is part of the requirements when deciding on the minimum number of requirements that should be met.
For example in this picture:
It is unclear that the allowlist is a requirement and that a user needs to either meet the token threshold or be in the allowlist.
Same here:
Additional context
This caused "bugs" like #9690.
The text was updated successfully, but these errors were encountered: