Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all hardcoded ABIs to libs/shared #9894

Open
timolegros opened this issue Nov 13, 2024 · 0 comments · May be fixed by #9915
Open

Move all hardcoded ABIs to libs/shared #9894

timolegros opened this issue Nov 13, 2024 · 0 comments · May be fixed by #9915
Assignees
@timolegros
Labels
1 1-2 hour task cleanup

Comments

@timolegros
Copy link
Collaborator

Description

We have ABIs hardcoded in packages/commonwealth/client/scripts/helpers/ContractHelpers/Abi and libs/model/src/services/commonProtocol/abi. We should move all of these ABIs to libs/shared.

Additional context
@timolegros timolegros added cleanup 1 1-2 hour task labels Nov 13, 2024
@timolegros timolegros self-assigned this Nov 13, 2024
This was referenced Nov 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timolegros timolegros

Labels
1 1-2 hour task cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Centralize ABIs hicommonwealth/commonwealth
1 participant
@timolegros