[#2108] Add test for StatelessSession insertAll in batch does not do batching

Author: dreab8

hibernate-reactive-core/src/test/java/org/hibernate/PersistAllWithNoBatchSizeConfiguredTest.java

@@ -0,0 +1,149 @@
+/* Hibernate, Relational Persistence for Idiomatic Java
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ * Copyright: Red Hat Inc. and Hibernate Authors
+ */
+package org.hibernate;
+
+import java.util.Objects;
+import java.util.Set;
+
+import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
+import org.hibernate.cfg.Configuration;
+import org.hibernate.reactive.BaseReactiveTest;
+import org.hibernate.reactive.testing.SqlStatementTracker;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import io.vertx.junit5.Timeout;
+import io.vertx.junit5.VertxTestContext;
+import jakarta.persistence.Entity;
+import jakarta.persistence.Id;
+import jakarta.persistence.Table;
+import jakarta.persistence.Version;
+
+import static java.util.concurrent.TimeUnit.MINUTES;
+import static org.assertj.core.api.Assertions.assertThat;
+
+@Timeout(value = 10, timeUnit = MINUTES)
+public class PersistAllWithNoBatchSizeConfiguredTest extends BaseReactiveTest {
+	private static SqlStatementTracker sqlTracker;
+
+	@Override
+	protected Set<Class<?>> annotatedEntities() {
+		return Set.of( GuineaPig.class );
+	}
+
+	@Override
+	protected Configuration constructConfiguration() {
+		Configuration configuration = super.constructConfiguration();
+
+		// Construct a tracker that collects query statements via the SqlStatementLogger framework.
+		// Pass in configuration properties to hand off any actual logging properties
+		sqlTracker = new SqlStatementTracker(
+				PersistAllWithNoBatchSizeConfiguredTest::filter,
+				configuration.getProperties()
+		);
+		return configuration;
+	}
+
+	@BeforeEach
+	public void clearTracker() {
+		sqlTracker.clear();
+	}
+
+	protected void addServices(StandardServiceRegistryBuilder builder) {
+		sqlTracker.registerService( builder );
+	}
+
+	private static boolean filter(String s) {
+		String[] accepted = { "insert ", "update ", "delete " };
+		for ( String valid : accepted ) {
+			if ( s.toLowerCase().startsWith( valid ) ) {
+				return true;
+			}
+		}
+		return false;
+	}
+
+	@Test
+	public void testBatchingWithStateless(VertxTestContext context) {
+		final GuineaPig[] pigs = {
+				new GuineaPig( 11, "One" ),
+				new GuineaPig( 22, "Two" ),
+				new GuineaPig( 33, "Three" ),
+				new GuineaPig( 44, "Four" ),
+				new GuineaPig( 55, "Five" ),
+				new GuineaPig( 66, "Six" ),
+		};
+		test( context, getMutinySessionFactory()
+				.withStatelessTransaction( s -> s.insertAll( 10, pigs ) )
+				.invoke( () -> {
+					// We expect only one insert query
+					assertThat( sqlTracker.getLoggedQueries() ).hasSize( 1 );
+					// Parameters are different for different dbs, so we cannot do an exact match
+					assertThat( sqlTracker.getLoggedQueries().get( 0 ) )
+							.matches("insert into pig \\(name,version,id\\) values (.*)" );
+					sqlTracker.clear();
+				} )
+		);
+	}
+
+	@Entity(name = "GuineaPig")
+	@Table(name = "pig")
+	public static class GuineaPig {
+		@Id
+		private Integer id;
+		private String name;
+		@Version
+		private int version;
+
+		public GuineaPig() {
+		}
+
+		public GuineaPig(Integer id, String name) {
+			this.id = id;
+			this.name = name;
+		}
+
+		public Integer getId() {
+			return id;
+		}
+
+		public void setId(Integer id) {
+			this.id = id;
+		}
+
+		public String getName() {
+			return name;
+		}
+
+		public void setName(String name) {
+			this.name = name;
+		}
+
+		@Override
+		public String toString() {
+			return id + ": " + name;
+		}
+
+		@Override
+		public boolean equals(Object o) {
+			if ( this == o ) {
+				return true;
+			}
+			if ( o == null || getClass() != o.getClass() ) {
+				return false;
+			}
+			GuineaPig guineaPig = (GuineaPig) o;
+			return Objects.equals( name, guineaPig.name );
+		}
+
+		@Override
+		public int hashCode() {
+			return Objects.hash( name );
+		}
+	}
+
+}

hibernate-reactive-core/src/test/java/org/hibernate/reactive/BatchingConnectionTest.java

@@ -168,6 +168,29 @@ public void testBatchingWithStateless(VertxTestContext context) {
 		);
 	}
 
+	@Test
+	public void testInsertAllWithStateless(VertxTestContext context) {
+		final GuineaPig[] pigs = {
+				new GuineaPig( 11, "One" ),
+				new GuineaPig( 22, "Two" ),
+				new GuineaPig( 33, "Three" ),
+				new GuineaPig( 44, "Four" ),
+				new GuineaPig( 55, "Five" ),
+				new GuineaPig( 66, "Six" ),
+		};
+		test( context, getMutinySessionFactory()
+				.withStatelessTransaction( s -> s.insertAll( pigs ) )
+				.invoke( () -> {
+					// We only 2 insert queries, batch size is 5 and we have 6 inserts
+					assertThat( sqlTracker.getLoggedQueries() ).hasSize( 2 );
+					// Parameters are different for different dbs, so we cannot do an exact match
+					assertThat( sqlTracker.getLoggedQueries().get( 0 ) )
+							.matches("insert into pig \\(name,version,id\\) values (.*)" );
+					sqlTracker.clear();
+				} )
+		);
+	}
+
 	@Test
 	public void testBatchingConnection(VertxTestContext context) {
 		test( context, openSession()