Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underscores at the end of fitted attributes so scikit-learn can determine fit status #37

Open
lukethomrichardson opened this issue Feb 6, 2025 · 0 comments

Comments

@lukethomrichardson
Copy link

Hello, thanks for maintaining a great package. Scikit-learn determines if an estimator is fitted by evaluating whether it contains attributes that end with an underscore (e.g., self.alpha_). Currently, absence of these attributes lead scikit-learn to conclude that pipelines that end with a WrapClassifier (or other crepes predictor object) are not fitted, even if the wrapped learner is fitted. I recommend including these underscored attributes in variables that are fitted in the calibrate methods of WrapClassifier (and others where appropriate). According to sklearn FutureWarnings in 1.6.1, this will start to cause problems in sklearn 1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant