Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "choose on map" for routing start/end location #114

Open
mradamcox opened this issue Aug 23, 2022 · 4 comments
Open

Allow "choose on map" for routing start/end location #114

mradamcox opened this issue Aug 23, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mradamcox
Copy link

It would be nice to have the option of clicking/tapping a spot on the map to enter that as the start (or end) point of the route.

Just wanted to put it out there, because, as other tickets and HN comments have mentioned, the address autocomplete isn't super sophisticated yet, so adding this functionality would make a it just a bit easier to use the routing capabilities in the meantime.

For example, my home address doesn't appear in the autocomplete at all, so I typed in a nearby restaurant which did pop up. With that location set as the destination, having the option to click near my house would be super convenient. For a variety of reasons, I find that I use that functionality on Google Maps quite a lot, actually.

Thanks for this ambitious project! I'm looking forward to following it :)

@ellenhp ellenhp added the enhancement New feature or request label Aug 23, 2022
@ellenhp
Copy link
Member

ellenhp commented Aug 23, 2022

This is definitely something I want to support! Currently you can drop a pin on desktop only by long-pressing the map while nothing is selected, but as soon as you're in the directions screen you can't drop pins anymore, so it's currently only useful for selecting a destination. It's also not discoverable enough.

@mradamcox
Copy link
Author

Ok, I see the long-press now, I like the use of that event a lot. That same interaction could auto fill the "From" box.

@ellenhp
Copy link
Member

ellenhp commented Aug 23, 2022

That's what I'm thinking. In the directions screen if exactly one of the boxes is not filled, the long-press should drop a pin and fill it.

Do you think that will be discoverable enough?

@ellenhp ellenhp self-assigned this Aug 28, 2022
@ellenhp ellenhp added this to the Release 0.1 milestone Aug 28, 2022
@kresp0
Copy link
Contributor

kresp0 commented Sep 10, 2022

That's what I'm thinking. In the directions screen if exactly one of the boxes is not filled, the long-press should drop a pin and fill it.

And if neither are filled, I think it should fill the destination, on any screen.

Do you think that will be discoverable enough?

Why not a simple tap/click instead of a long one? This way should be way more discoverable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants