-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation describing how to update the plugin protocol #36592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just contemplating removing this whole mess of paperwork for protocol changes. The idea was that external groups could easily reference a specific point release for the protobbuf without pulling it from VCS, but it's created this whole mess of process and leads itself to either be forgotten or extra versions created, and we have no sane diffs for review.
Maybe we go back to minor releases editing the files in place?
… per Terraform minor release.
I feel too new to have an opinion. I can definitely see there's risk around accidentally making >1 new minor version per TF minor version and I'm not sure how that could be protected against (could make a GHA?). For now having this PR's write up is useful as a way to make this more accessible with its current process. |
Yeah, the minor version thing can't be protected against, but I really just want regular diffs 😸 |
Documenting the process for updating the protocol - thanks to @dbanck for help with the process around symlinks!
Target Release
N/A
CHANGELOG entry